Remove PhutilPhtTestCase::getDateTranslations()
ClosedPublic
Actions

Authored by pppery on Jun 7 2024, 16:55.

Details

Reviewers

aklapper

Group Reviewers

O1: Blessed Committers

Commits

rARCf7fcf31c7e23: Remove PhutilPhtTestCase::getDateTranslations()

Summary

See my comment at T15815#17864. I don't think the translation extractor has any consumers other than the downstream translations extension, and I'd prefer to handle this issue there rather than upstream.

Test Plan

Read the code.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

pppery created this revision.Jun 7 2024, 16:55

Owners added a reviewer: O1: Blessed Committers.Jun 7 2024, 16:55

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptJun 7 2024, 16:55

pppery requested review of this revision.Jun 7 2024, 16:55

Harbormaster completed remote builds in B1334: Diff 2094.Jun 7 2024, 16:55

pppery edited the summary of this revision. (Show Details)Jun 7 2024, 16:57

I cannot find getDateTranslations anywhere so I'm having the (probably very stupid) question where this function was called once upon a time (edit: oh well, I now realize it's a test case so I guess this just gets executed when running tests. sigh.).

No, it never was called anywhere. Read the HTML comment this commit deletes.

This situation is so bizarre that I dismissed it as inconceivable back in April when I was dealing with the downstream AM/PM exception, yet here we are.

Ah, thanks.

This revision is now accepted and ready to land.Jun 7 2024, 19:04

Closed by commit rARCf7fcf31c7e23: Remove PhutilPhtTestCase::getDateTranslations(). · Explain WhyJun 7 2024, 19:10

This revision was automatically updated to reflect the committed changes.

pppery added a commit: rARCf7fcf31c7e23: Remove PhutilPhtTestCase::getDateTranslations().