Page MenuHomePhorge

Fix call to non-existing getTransactionCommentForSave() in PhabricatorInlineComment
ClosedPublic

Authored by aklapper on May 16 2024, 10:25.

Details

Summary

rPb48a22bf50a32895566e9aa66c1d7aff87a492b8 moved the call $this->getTransactionCommentForSave()->save() from within PhabricatorAuditInlineComment to the new (parent) class PhabricatorInlineComment.php, however the later does not define this function.

As the two child classes which extend PhabricatorInlineComment both implement getTransactionCommentForSave(), declare an abstract function in their parent class.

Test Plan

Carefully read the code.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Maybe a good moment for minimal PHPDoc with

/**
 * @return Phobject
 */

sgtm

grep -R 'extends PhabricatorInlineComment *{' .
./applications/audit/storage/PhabricatorAuditInlineComment.php:  extends PhabricatorInlineComment {
./applications/differential/storage/DifferentialInlineComment.php:  extends PhabricatorInlineComment {
grep -R 'function getTransactionCommentForSave(' .
./applications/audit/storage/PhabricatorAuditInlineComment.php:  public function getTransactionCommentForSave() {
./applications/differential/storage/DifferentialInlineComment.php:  public function getTransactionCommentForSave() {
This revision is now accepted and ready to land.Jun 7 2024, 15:10