Fix call to non-existing getTransactionCommentForSave() in PhabricatorInlineComment
ClosedPublic
Actions

Authored by aklapper on May 16 2024, 10:25.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Commits

rPd2bca2f32da0: Fix call to non-existing getTransactionCommentForSave() in…

Summary

rPb48a22bf50a32895566e9aa66c1d7aff87a492b8 moved the call $this->getTransactionCommentForSave()->save() from within PhabricatorAuditInlineComment to the new (parent) class PhabricatorInlineComment.php, however the later does not define this function.

As the two child classes which extend PhabricatorInlineComment both implement getTransactionCommentForSave(), declare an abstract function in their parent class.

Test Plan

Carefully read the code.

Diff Detail

Repository

rP Phorge

Branch

NEinlineCommentForSave (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1336
Build 1336: arc lint + arc unit

Event Timeline

aklapper created this revision.May 16 2024, 10:25

Owners added a reviewer: O1: Blessed Committers.May 16 2024, 10:25

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptMay 16 2024, 10:25

aklapper requested review of this revision.May 16 2024, 10:25

Harbormaster completed remote builds in B1265: Diff 1995.May 16 2024, 10:25

valerio.bozzolan awarded a token.May 16 2024, 12:18

Maybe a good moment for minimal PHPDoc with

/**
 * @return Phobject
 */

sgtm

grep -R 'extends PhabricatorInlineComment *{' .
./applications/audit/storage/PhabricatorAuditInlineComment.php:  extends PhabricatorInlineComment {
./applications/differential/storage/DifferentialInlineComment.php:  extends PhabricatorInlineComment {

grep -R 'function getTransactionCommentForSave(' .
./applications/audit/storage/PhabricatorAuditInlineComment.php:  public function getTransactionCommentForSave() {
./applications/differential/storage/DifferentialInlineComment.php:  public function getTransactionCommentForSave() {

valerio.bozzolan accepted this revision.Jun 7 2024, 15:10

This revision is now accepted and ready to land.Jun 7 2024, 15:10

Add minimal PHPDoc

Harbormaster completed remote builds in B1336: Diff 2096.Jun 7 2024, 17:18

Closed by commit rPd2bca2f32da0: Fix call to non-existing getTransactionCommentForSave() in…. · Explain WhyJun 7 2024, 17:28

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rPd2bca2f32da0: Fix call to non-existing getTransactionCommentForSave() in….