Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception creating a Portal
ClosedPublic

Authored by aklapper on Jun 5 2024, 11:44.
Tags
None
Referenced Files
F3801276: D25681.1745945797.diff
Mon, Apr 28, 16:56
F3761087: D25681.1745830202.diff
Sun, Apr 27, 08:50
F3712065: D25681.1745669560.diff
Fri, Apr 25, 12:12
F3686449: D25681.1745580564.diff
Thu, Apr 24, 11:29
F3658049: D25681.1745454162.diff
Wed, Apr 23, 00:22
F3502995: D25681.1744797649.diff
Tue, Apr 15, 10:00
F3371614: D25681.1744243951.diff
Wed, Apr 9, 00:12
F3368708: D25681.1744210611.diff
Tue, Apr 8, 14:56

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/dashboard/menuitem/PhabricatorDashboardPortalMenuItem.php:34]

Closes T15847

Test Plan

Go to /portal/edit/form/default/, set a name and click Create Portal.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable