Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception creating a Portal
ClosedPublic

Authored by aklapper on Jun 5 2024, 11:44.
Tags
None
Referenced Files
F3216645: D25681.1741707721.diff
Mon, Mar 10, 15:42
F3172053: D25681.1741278824.diff
Wed, Mar 5, 16:33
F3169262: D25681.1741270104.diff
Wed, Mar 5, 14:08
F3167338: D25681.1741264828.diff
Wed, Mar 5, 12:40
F2999368: D25681.1740424975.diff
Sun, Feb 23, 19:22
F2996025: D25681.1740361244.diff
Sun, Feb 23, 01:40
F2996024: D25681.1740361243.diff
Sun, Feb 23, 01:40
F2995865: D25681.1740356141.diff
Sun, Feb 23, 00:15

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/dashboard/menuitem/PhabricatorDashboardPortalMenuItem.php:34]

Closes T15847

Test Plan

Go to /portal/edit/form/default/, set a name and click Create Portal.

Diff Detail

Repository
rP Phorge
Branch
strlenPortals (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1322
Build 1322: arc lint + arc unit