Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception creating a Portal
ClosedPublic

Authored by aklapper on Jun 5 2024, 11:44.
Tags
None
Referenced Files
F3309833: D25681.1743187963.diff
Thu, Mar 27, 18:52
F3303404: D25681.1743080537.diff
Wed, Mar 26, 13:02
F3300591: D25681.1743042369.diff
Wed, Mar 26, 02:26
F3298146: D25681.1742997676.diff
Tue, Mar 25, 14:01
F3293150: D25681.1742908328.diff
Mon, Mar 24, 13:12
F3290631: D25681.1742869698.diff
Mon, Mar 24, 02:28
F3252662: D25681.1742397773.diff
Tue, Mar 18, 15:22
F3251667: D25681.1742365250.diff
Tue, Mar 18, 06:20

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/dashboard/menuitem/PhabricatorDashboardPortalMenuItem.php:34]

Closes T15847

Test Plan

Go to /portal/edit/form/default/, set a name and click Create Portal.

Diff Detail

Repository
rP Phorge
Branch
strlenPortals (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1322
Build 1322: arc lint + arc unit