Page MenuHomePhorge
Differential D25666

PHPMailer: Remove duplicate array keys
ClosedPublic
Actions

Authored by aklapper on May 20 2024, 08:43.

Details

Reviewers
avivey
Group Reviewers
O1: Blessed Committers
Commits
rP67c0efdffb79: PHPMailer: Remove duplicate array keys
Summary

'doc' is listed twice in the $mimes array. Remove one key.

The second key was also removed in https://github.com/PHPMailer/PHPMailer/commit/6f919df65e80023fce4eab58832b6035b4a41935.

Test Plan

Read/grep the code.

Diff Detail

Repository
rP Phorge
Branch
phpmailerDupArrayDoc (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 1292
Build 1292: arc lint + arc unit

Event Timeline

aklapper created this revision.May 20 2024, 08:43
Owners added a reviewer: O1: Blessed Committers.May 20 2024, 08:43
Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptMay 20 2024, 08:43
Harbormaster completed remote builds in B1292: Diff 2033.May 20 2024, 08:43
aklapper requested review of this revision.May 20 2024, 08:43
aklapper retitled this revision from PHPMailer: Remove duplicate array entry to PHPMailer: Remove duplicate array keys.May 20 2024, 08:45
aklapper edited the summary of this revision. (Show Details)
avivey accepted this revision.May 21 2024, 08:31
This revision is now accepted and ready to land.May 21 2024, 08:31
Closed by commit rP67c0efdffb79: PHPMailer: Remove duplicate array keys. · Explain WhyMay 21 2024, 09:07
This revision was automatically updated to reflect the committed changes.
aklapper added a commit: rP67c0efdffb79: PHPMailer: Remove duplicate array keys.

Revision Contents
Changeset List

Diff 2033

View Options

externals/phpmailer/class.phpmailer-lite.php

Loading...
View Options

externals/phpmailer/class.phpmailer.php

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0