Differential D25663

PHPMailer: Remove check for non-existing get_magic_quotes()
ClosedPublic
Actions

Authored by aklapper on May 18 2024, 23:12.

Tags

None

Referenced Files

	F2948734: D25663.1738589957.diff
	Sun, Feb 2, 13:39

	F2944557: D25663.1738273081.diff
	Wed, Jan 29, 21:38

	F2938398: D25663.1737994465.diff
	Sun, Jan 26, 16:14

	F2933036: D25663.1737750951.diff
	Thu, Jan 23, 20:35

	F2933035: D25663.1737750950.diff
	Thu, Jan 23, 20:35

	F2932921: D25663.1737746596.diff
	Thu, Jan 23, 19:23

	F2870093: D25663.1736769554.diff
	Sun, Jan 12, 11:59

	F2863123: D25663.1736475222.diff
	Thu, Jan 9, 02:13

Subscribers

valerio.bozzolan

Details

Reviewers

Group Reviewers

O1: Blessed Committers

Commits

rP601ac4503276: PHPMailer: Remove check for non-existing get_magic_quotes()

Summary

No idea if PHP ever offered such a method. In any case, this very check was removed in https://github.com/PHPMailer/PHPMailer/commit/6f919df65e80023fce4eab58832b6035b4a41935#diff-2d294eae28fb0d70fc32da8369c4fe33d301c99ca3eeb4bd41da18ad99344d68 in 2012.

Test Plan

Not sure - how to test a removed check for a method which does not exist anyway? :)

Diff Detail

Repository

Branch

NEgetMagicQuotes (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 1288
Build 1288: arc lint + arc unit

Event Timeline

aklapper created this revision.May 18 2024, 23:12

Owners added a reviewer: O1: Blessed Committers.May 18 2024, 23:12

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptMay 18 2024, 23:12

Harbormaster completed remote builds in B1288: Diff 2026.May 18 2024, 23:12

aklapper requested review of this revision.May 18 2024, 23:12

avivey accepted this revision.May 19 2024, 06:06

This revision is now accepted and ready to land.May 19 2024, 06:06

aklapper retitled this revision from PHPMailer: Remove check for non-existing `get_magic_quotes` to PHPMailer: Remove check for non-existing get_magic_quotes().May 19 2024, 08:19

Closed by commit rP601ac4503276: PHPMailer: Remove check for non-existing get_magic_quotes(). · Explain WhyMay 19 2024, 08:20

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rP601ac4503276: PHPMailer: Remove check for non-existing get_magic_quotes().

Revision Contents
Changeset List

Path

Size

Packages

externals/

phpmailer/

class.phpmailer-lite.php

5 lines

O1: Blessed Committers

class.phpmailer.php

5 lines

O1: Blessed Committers

Diff 2026

externals/phpmailer/class.phpmailer-lite.php

Loading...

externals/phpmailer/class.phpmailer.php

Loading...