Fix calls to non-existing getDescription() in ArcanistWorkingCopyPath
ClosedPublic
Actions

Authored by aklapper on May 17 2024, 09:47.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Commits

rARC3cb117684f4e: Fix calls to non-existing getDescription() in ArcanistWorkingCopyPath

Summary

ArcanistWorkingCopyPath::getDescription() is undefined. Given its use in the exception message, the path is supposed to be used, so call ArcanistWorkingCopyPath::getPath() instead.

Test Plan

Carefully read the code and check for existing methods in the class.

Diff Detail

Repository

rARC Arcanist

Branch

NEworkingCopyPath (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1280
Build 1280: arc lint + arc unit

Event Timeline

aklapper created this revision.May 17 2024, 09:47

Owners added a reviewer: O1: Blessed Committers.May 17 2024, 09:47

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptMay 17 2024, 09:47

aklapper requested review of this revision.May 17 2024, 09:47

Harbormaster completed remote builds in B1280: Diff 2011.May 17 2024, 09:47

valerio.bozzolan requested changes to this revision.May 18 2024, 13:33

valerio.bozzolan added inline comments.

src/workingcopy/ArcanistWorkingCopyPath.php
33	I think this should just try to show the path. See line 97. We are sure that `$path` is something that can be casted to string, but we are unsure if that's an object with a `getDescription()` method.
58	Same