Page MenuHomePhorge

Fix calls to non-existing getDescription() in ArcanistWorkingCopyPath
ClosedPublic

Authored by aklapper on May 17 2024, 09:47.

Details

Summary

ArcanistWorkingCopyPath::getDescription() is undefined. Given its use in the exception message, the path is supposed to be used, so call ArcanistWorkingCopyPath::getPath() instead.

Test Plan

Carefully read the code and check for existing methods in the class.

Diff Detail

Repository
rARC Arcanist
Branch
NEworkingCopyPath (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1289
Build 1289: arc lint + arc unit

Event Timeline

valerio.bozzolan added inline comments.
src/workingcopy/ArcanistWorkingCopyPath.php
33

I think this should just try to show the path.

See line 97. We are sure that $path is something that can be casted to string, but we are unsure if that's an object with a getDescription() method.

58

Same

This revision now requires changes to proceed.May 18 2024, 13:33

Valerio may have a point here :D

aklapper edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.May 19 2024, 05:11