Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception rendering files/documents
ClosedPublic

Authored by aklapper on May 13 2024, 17:49.
Tags
None
Referenced Files
F3010045: D25638.1740626521.diff
Wed, Feb 26, 03:22
F3010044: D25638.1740626518.diff
Wed, Feb 26, 03:21
F3010029: D25638.1740626354.diff
Wed, Feb 26, 03:19
F3010024: D25638.1740626040.diff
Wed, Feb 26, 03:14
F2952296: D25638.1738963800.diff
Feb 6 2025, 21:30
F2950072: D25638.1738710674.diff
Feb 3 2025, 23:11
F2936750: D25638.1737938240.diff
Jan 26 2025, 00:37
F2936653: D25638.1737934142.diff
Jan 25 2025, 23:29

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/files/document/render/PhabricatorDocumentRenderingEngine.php:211]

Closes T15826

Test Plan

Surf a Diffusion repository and play with View Options.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable