Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception rendering files/documents
ClosedPublic

Authored by aklapper on May 13 2024, 17:49.
Tags
None
Referenced Files
F2936750: D25638.1737938240.diff
Sun, Jan 26, 00:37
F2936653: D25638.1737934142.diff
Sat, Jan 25, 23:29
F2933534: D25638.1737773975.diff
Fri, Jan 24, 02:59
F2933533: D25638.1737773973.diff
Fri, Jan 24, 02:59
F2933532: D25638.1737773968.diff
Fri, Jan 24, 02:59
F2933469: D25638.1737770598.diff
Fri, Jan 24, 02:03
F2919961: D25638.1737538817.diff
Tue, Jan 21, 09:40
F2871177: D25638.1736838846.diff
Mon, Jan 13, 07:14

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/files/document/render/PhabricatorDocumentRenderingEngine.php:211]

Closes T15826

Test Plan

Surf a Diffusion repository and play with View Options.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable