Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception rendering files/documents
ClosedPublic

Authored by aklapper on May 13 2024, 17:49.

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/files/document/render/PhabricatorDocumentRenderingEngine.php:211]

Closes T15826

Test Plan

Surf a Diffusion repository and play with View Options.

Diff Detail

Repository
rP Phorge
Branch
T15826strlenFileEncoding (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1254
Build 1254: arc lint + arc unit