Paths

Table of Contentst

Differential D25605

PhutilRemarkupHexColorCodeRule: Do not assume that parameter is a string
ClosedPublic
Actions

Authored by aklapper on Apr 29 2024, 20:23.

Tags

None

Referenced Files

	F3355820: D25605.1743877690.diff
	Fri, Apr 4, 18:28

	F3354542: D25605.1743862184.diff
	Fri, Apr 4, 14:09

	F3353935: D25605.1743844558.diff
	Fri, Apr 4, 09:15

	F3353316: D25605.1743832674.diff
	Fri, Apr 4, 05:57

	F3353041: D25605.1743822103.diff
	Fri, Apr 4, 03:01

	F3350160: D25605.1743762843.diff
	Thu, Apr 3, 10:34

	F3348805: D25605.1743743609.diff
	Thu, Apr 3, 05:13

	F3348213: D25605.1743734749.diff
	Thu, Apr 3, 02:45

View All 50 Files

Subscribers

valerio.bozzolan

Tokens

"Pirate Logo" token, awarded by aklapper."Pterodactyl" token, awarded by valerio.bozzolan.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15802: Regression: HTML entities rendered as plain text in config option descriptions

Commits

rP6ab2b56a1a4a: PhutilRemarkupHexColorCodeRule: Do not assume that parameter is a string

Summary

Check type before potentially mangling HTML in a PhutilSafeHTML element.
For now, do not try to apply this renderer when not dealing with a plain string.

Closes T15802

Test Plan

After deleting the corresponding MarkupCache via DELETE FROM phabricator_cache.cache_markupcache WHERE cacheData LIKE "%whatever description on the page%"; check the description of a page, e.g. of /config/edit/security.require-https/ or /config/edit/storage.default-namespace/.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aklapper created this revision.Apr 29 2024, 20:23

Owners added a reviewer: O1: Blessed Committers.Apr 29 2024, 20:23

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptApr 29 2024, 20:23

aklapper requested review of this revision.Apr 29 2024, 20:23

Harbormaster completed remote builds in B1203: Diff 1907.Apr 29 2024, 20:23

Interesting. Thanks.

Added minor tip.

src/infrastructure/markup/markuprule/PhutilRemarkupHexColorCodeRule.php
17–19

This revision is now accepted and ready to land.Apr 29 2024, 20:41

Documentation is arrsum

Harbormaster completed remote builds in B1204: Diff 1908.Apr 29 2024, 22:25

aklapper marked an inline comment as done.Apr 29 2024, 22:25

Double-accept. This means you unlocked a rare pterodactyl1!1

valerio.bozzolan awarded a token.Apr 30 2024, 05:36

valerio.bozzolan added inline comments.

src/infrastructure/markup/markuprule/PhutilRemarkupRule.php
21	THIS STAR IS SUPER-IMPORTANT THE WHOLE INSFRASTRUCTURE IS BASED ON THIS

aklapper awarded a token.Apr 30 2024, 07:21

Use correct markup for comment about markup

Harbormaster completed remote builds in B1205: Diff 1909.Apr 30 2024, 07:26

aklapper marked an inline comment as done.Apr 30 2024, 07:27

Closed by commit rP6ab2b56a1a4a: PhutilRemarkupHexColorCodeRule: Do not assume that parameter is a string. · Explain WhyApr 30 2024, 07:28

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rP6ab2b56a1a4a: PhutilRemarkupHexColorCodeRule: Do not assume that parameter is a string.

Revision Contents
Changeset List

Path

Size

Packages

src/

infrastructure/

markup/

markuprule/

PhutilRemarkupHexColorCodeRule.php

11 lines

O1: Blessed Committers

PhutilRemarkupRule.php

6 lines

O1: Blessed Committers

Diff 1910

src/infrastructure/markup/markuprule/PhutilRemarkupHexColorCodeRule.php

Loading...

src/infrastructure/markup/markuprule/PhutilRemarkupRule.php

Loading...