Paths

Table of Contentst

-
src/infrastructure/markup/markuprule/
-
infrastructure/
-
markup/
-
markuprule/
-
PhutilRemarkupHexColorCodeRule.php

Differential D25605

PhutilRemarkupHexColorCodeRule: Do not assume that parameter is a string
ClosedPublic
Actions

Authored by aklapper on Apr 29 2024, 20:23.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15802: Regression: HTML entities rendered as plain text in config option descriptions

Commits

rP6ab2b56a1a4a: PhutilRemarkupHexColorCodeRule: Do not assume that parameter is a string

Summary

Check type before potentially mangling HTML in a PhutilSafeHTML element.
For now, do not try to apply this renderer when not dealing with a plain string.

Closes T15802

Test Plan

After deleting the corresponding MarkupCache via DELETE FROM phabricator_cache.cache_markupcache WHERE cacheData LIKE "%whatever description on the page%"; check the description of a page, e.g. of /config/edit/security.require-https/ or /config/edit/storage.default-namespace/.

Diff Detail

Repository

rP Phorge

Branch

T15802 (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1203
Build 1203: arc lint + arc unit

Event Timeline

aklapper created this revision.Apr 29 2024, 20:23

Owners added a reviewer: O1: Blessed Committers.Apr 29 2024, 20:23

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptApr 29 2024, 20:23

aklapper requested review of this revision.Apr 29 2024, 20:23

Harbormaster completed remote builds in B1203: Diff 1907.Apr 29 2024, 20:23

Interesting. Thanks.

Added minor tip.

src/infrastructure/markup/markuprule/PhutilRemarkupHexColorCodeRule.php
17–19

This revision is now accepted and ready to land.Apr 29 2024, 20:41

Documentation is arrsum

Harbormaster completed remote builds in B1204: Diff 1908.Apr 29 2024, 22:25

aklapper marked an inline comment as done.Apr 29 2024, 22:25

Double-accept. This means you unlocked a rare pterodactyl1!1

valerio.bozzolan awarded a token.Apr 30 2024, 05:36

valerio.bozzolan added inline comments.

src/infrastructure/markup/markuprule/PhutilRemarkupRule.php
21 ↗	(On Diff #1908)	THIS STAR IS SUPER-IMPORTANT THE WHOLE INSFRASTRUCTURE IS BASED ON THIS

aklapper awarded a token.Apr 30 2024, 07:21

Use correct markup for comment about markup

Harbormaster completed remote builds in B1205: Diff 1909.Apr 30 2024, 07:26

aklapper marked an inline comment as done.Apr 30 2024, 07:27

Closed by commit rP6ab2b56a1a4a: PhutilRemarkupHexColorCodeRule: Do not assume that parameter is a string. · Explain WhyApr 30 2024, 07:28

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rP6ab2b56a1a4a: PhutilRemarkupHexColorCodeRule: Do not assume that parameter is a string.

Revision Contents
Changeset List

Path

Size

Packages

src/

infrastructure/

markup/

markuprule/

PhutilRemarkupHexColorCodeRule.php

12 lines

O1: Blessed Committers

Diff 1907

View Options

src/infrastructure/markup/markuprule/PhutilRemarkupHexColorCodeRule.php

Show First 20 Lines • Show All 61 Lines • ▼ Show 20 Lines	return array(
FilesDefaultViewCapability::CAPABILITY => array(		FilesDefaultViewCapability::CAPABILITY => array(
'caption' => pht('Default view policy for newly created files.'),		'caption' => pht('Default view policy for newly created files.'),
'template' => PhabricatorFileFilePHIDType::TYPECONST,		'template' => PhabricatorFileFilePHIDType::TYPECONST,
'capability' => PhabricatorPolicyCapability::CAN_VIEW,		'capability' => PhabricatorPolicyCapability::CAN_VIEW,
),		),
);		);
}		}

		public function getMonograms() {
		return array('F');
		}

public function getRoutes() {		public function getRoutes() {
return array(		return array(
'/F(?P<id>[1-9]\d*)(?:\$(?P<lines>\d+(?:-\d+)?))?'		'/F(?P<id>[1-9]\d*)(?:\$(?P<lines>\d+(?:-\d+)?))?'
=> 'PhabricatorFileViewController',		=> 'PhabricatorFileViewController',
'/file/' => array(		'/file/' => array(
'(query/(?P<queryKey>[^/]+)/)?' => 'PhabricatorFileListController',		'(query/(?P<queryKey>[^/]+)/)?' => 'PhabricatorFileListController',
'view/(?P<id>[1-9]\d*)/'.		'view/(?P<id>[1-9]\d*)/'.
'(?:(?P<engineKey>[^/]+)/)?'.		'(?:(?P<engineKey>[^/]+)/)?'.
▲ Show 20 Lines • Show All 78 Lines • Show Last 20 Lines

PhutilRemarkupHexColorCodeRule: Do not assume that parameter is a stringClosedPublicActions