Check type before potentially mangling HTML in a PhutilSafeHTML element.
For now, do not try to apply this renderer when not dealing with a plain string.
Closes T15802
Details
Details
- Reviewers
valerio.bozzolan - Group Reviewers
O1: Blessed Committers - Maniphest Tasks
- T15802: Regression: HTML entities rendered as plain text in config option descriptions
- Commits
- rP6ab2b56a1a4a: PhutilRemarkupHexColorCodeRule: Do not assume that parameter is a string
After deleting the corresponding MarkupCache via DELETE FROM phabricator_cache.cache_markupcache WHERE cacheData LIKE "%whatever description on the page%"; check the description of a page, e.g. of /config/edit/security.require-https/ or /config/edit/storage.default-namespace/.
Diff Detail
Diff Detail
- Repository
- rP Phorge
- Branch
- T15802 (branched from master)
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 1203 Build 1203: arc lint + arc unit
Event Timeline
Comment Actions
Interesting. Thanks.
Added minor tip.
| src/infrastructure/markup/markuprule/PhutilRemarkupHexColorCodeRule.php | ||
|---|---|---|
| 17–19 | ||
| src/infrastructure/markup/markuprule/PhutilRemarkupRule.php | ||
|---|---|---|
| 21 ↗ | (On Diff #1908) | THIS STAR IS SUPER-IMPORTANT THE WHOLE INSFRASTRUCTURE IS BASED ON THIS |