Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception mass-editing tasks when custom Date field present
ClosedPublic

Authored by aklapper on Apr 19 2024, 15:56.
Tags
None
Referenced Files
F3220620: D25599.1741811286.diff
Tue, Mar 11, 20:28
F3219745: D25599.1741761228.diff
Tue, Mar 11, 06:33
F3215760: D25599.1741660637.diff
Mon, Mar 10, 02:37
F3215759: D25599.1741660633.diff
Mon, Mar 10, 02:37
F3151955: D25599.1741226968.diff
Wed, Mar 5, 02:09
F3151954: D25599.1741226966.diff
Wed, Mar 5, 02:09
F3147908: D25599.1741216537.diff
Tue, Mar 4, 23:15
F3082824: D25599.1741072542.diff
Mon, Mar 3, 07:15

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldDate.php:113]
ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldDate.php:120]

Closes T15794

Test Plan

Define a date field in maniphest.custom-field-definitions, have more than 100 Maniphest tasks, and select some to bulk-edit them. Example config:

{
  "mycompany.deadline": {
    "name": "Deadline",
    "type": "date",
    "caption": "Estimated deadline.",
    "search": true
  }
}

Diff Detail

Repository
rP Phorge
Branch
T15794customDateField (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1191
Build 1191: arc lint + arc unit