Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception mass-editing tasks when custom Date field present
ClosedPublic

Authored by aklapper on Apr 19 2024, 15:56.
Tags
None
Referenced Files
F2945069: D25599.1738285914.diff
Thu, Jan 30, 01:11
F2944582: D25599.1738273107.diff
Wed, Jan 29, 21:38
F2936985: D25599.1737944649.diff
Sun, Jan 26, 02:24
F2936317: D25599.1737911814.diff
Sat, Jan 25, 17:16
F2936316: D25599.1737911811.diff
Sat, Jan 25, 17:16
F2933147: D25599.1737751823.diff
Thu, Jan 23, 20:50
F2926727: D25599.1737641353.diff
Wed, Jan 22, 14:09
F2922538: D25599.1737573689.diff
Tue, Jan 21, 19:21

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldDate.php:113]
ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldDate.php:120]

Closes T15794

Test Plan

Define a date field in maniphest.custom-field-definitions, have more than 100 Maniphest tasks, and select some to bulk-edit them. Example config:

{
  "mycompany.deadline": {
    "name": "Deadline",
    "type": "date",
    "caption": "Estimated deadline.",
    "search": true
  }
}

Diff Detail

Repository
rP Phorge
Branch
T15794customDateField (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1191
Build 1191: arc lint + arc unit