Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception mass-editing tasks when custom Date field present
ClosedPublic

Authored by aklapper on Apr 19 2024, 15:56.
Tags
None
Referenced Files
F3605479: D25599.1745272045.diff
Sun, Apr 20, 21:47
F3604832: D25599.1745234596.diff
Sun, Apr 20, 11:23
F3553010: D25599.1744916209.diff
Wed, Apr 16, 18:56
F3531504: D25599.1744884083.diff
Wed, Apr 16, 10:01
F3477416: D25599.1744759849.diff
Mon, Apr 14, 23:30
F3383976: D25599.1744396512.diff
Thu, Apr 10, 18:35
F3372606: D25599.1744250520.diff
Wed, Apr 9, 02:02
F3369901: D25599.1744216837.diff
Tue, Apr 8, 16:40

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldDate.php:113]
ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldDate.php:120]

Closes T15794

Test Plan

Define a date field in maniphest.custom-field-definitions, have more than 100 Maniphest tasks, and select some to bulk-edit them. Example config:

{
  "mycompany.deadline": {
    "name": "Deadline",
    "type": "date",
    "caption": "Estimated deadline.",
    "search": true
  }
}

Diff Detail

Repository
rP Phorge
Branch
T15794customDateField (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1191
Build 1191: arc lint + arc unit