Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception mass-editing tasks when custom Date field present
ClosedPublic

Authored by aklapper on Apr 19 2024, 15:56.
Tags
None
Referenced Files
F4201645: D25599.1747221261.diff
Tue, May 13, 11:14
F4121799: D25599.1747045018.diff
Sun, May 11, 10:16
F4120906: D25599.1747038580.diff
Sun, May 11, 08:29
F4120332: D25599.1747033742.diff
Sun, May 11, 07:09
F4117913: D25599.1747005587.diff
Sat, May 10, 23:19
F4046046: D25599.1746737066.diff
Wed, May 7, 20:44
F4046045: D25599.1746737065.diff
Wed, May 7, 20:44
F4011392: D25599.1746625903.diff
Tue, May 6, 13:51

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldDate.php:113]
ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/infrastructure/customfield/standard/PhabricatorStandardCustomFieldDate.php:120]

Closes T15794

Test Plan

Define a date field in maniphest.custom-field-definitions, have more than 100 Maniphest tasks, and select some to bulk-edit them. Example config:

{
  "mycompany.deadline": {
    "name": "Deadline",
    "type": "date",
    "caption": "Estimated deadline.",
    "search": true
  }
}

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable