Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception for "/bin/files migrate" without parameter
ClosedPublic

Authored by aklapper on Tue, Apr 16, 22:58.
Tags
None
Referenced Files
F2169451: D25594.diff
Mon, Apr 29, 10:00
Unknown Object (File)
Sat, Apr 27, 15:36
Unknown Object (File)
Sat, Apr 27, 12:36
Unknown Object (File)
Sat, Apr 27, 07:12
Unknown Object (File)
Fri, Apr 26, 20:12
Unknown Object (File)
Wed, Apr 24, 22:30
Unknown Object (File)
Wed, Apr 24, 21:16
Unknown Object (File)
Wed, Apr 24, 07:59

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/files/management/PhabricatorFilesManagementMigrateWorkflow.php:65]
Test Plan

Run ../phorge/bin/files migrate: Get no strlen() error anymore but only expected output Usage Exception: Specify an engine to migrate to with --engine`. Use files engines to get a list of engines.`

Diff Detail

Repository
rP Phorge
Branch
cliFilesMigrateStrlen (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1186
Build 1186: arc lint + arc unit