Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception for "/bin/files migrate" without parameter
ClosedPublic

Authored by aklapper on Apr 16 2024, 22:58.
Tags
None
Referenced Files
F3307036: D25594.1743137355.diff
Thu, Mar 27, 04:49
F3306732: D25594.1743131531.diff
Thu, Mar 27, 03:12
F3284993: D25594.1742790502.diff
Sun, Mar 23, 04:28
F3249451: D25594.1742286167.diff
Mon, Mar 17, 08:22
F3151944: D25594.1741226956.diff
Wed, Mar 5, 02:09
F3151943: D25594.1741226955.diff
Wed, Mar 5, 02:09
F3147903: D25594.1741216534.diff
Tue, Mar 4, 23:15
F3082830: D25594.1741072546.diff
Mon, Mar 3, 07:15

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/files/management/PhabricatorFilesManagementMigrateWorkflow.php:65]
Test Plan

Run ../phorge/bin/files migrate: Get no strlen() error anymore but only expected output Usage Exception: Specify an engine to migrate to with --engine`. Use files engines to get a list of engines.`

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable