Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception for "/bin/files migrate" without parameter
ClosedPublic

Authored by aklapper on Apr 16 2024, 22:58.
Tags
None
Referenced Files
F2944595: D25594.1738273119.diff
Wed, Jan 29, 21:38
F2942567: D25594.1738119754.diff
Tue, Jan 28, 03:02
F2942562: D25594.1738119748.diff
Tue, Jan 28, 03:02
F2937371: D25594.1737954374.diff
Sun, Jan 26, 05:06
F2937000: D25594.1737945051.diff
Sun, Jan 26, 02:30
F2936638: D25594.1737933300.diff
Sat, Jan 25, 23:15
F2936375: D25594.1737915986.diff
Sat, Jan 25, 18:26
F2936374: D25594.1737915982.diff
Sat, Jan 25, 18:26

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/files/management/PhabricatorFilesManagementMigrateWorkflow.php:65]
Test Plan

Run ../phorge/bin/files migrate: Get no strlen() error anymore but only expected output Usage Exception: Specify an engine to migrate to with --engine`. Use files engines to get a list of engines.`

Diff Detail

Repository
rP Phorge
Branch
cliFilesMigrateStrlen (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1186
Build 1186: arc lint + arc unit