Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception for "/bin/files migrate" without parameter
ClosedPublic

Authored by aklapper on Apr 16 2024, 22:58.
Tags
None
Referenced Files
F3835429: D25594.1746085936.diff
Wed, Apr 30, 07:52
F3835428: D25594.1746085935.diff
Wed, Apr 30, 07:52
F3835427: D25594.1746085934.diff
Wed, Apr 30, 07:52
F3749107: D25594.1745790637.diff
Sat, Apr 26, 21:50
F3749106: D25594.1745790636.diff
Sat, Apr 26, 21:50
F3749105: D25594.1745790635.diff
Sat, Apr 26, 21:50
F3733997: D25594.1745754827.diff
Sat, Apr 26, 11:53
F3529100: D25594.1744860612.diff
Wed, Apr 16, 03:30

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/files/management/PhabricatorFilesManagementMigrateWorkflow.php:65]
Test Plan

Run ../phorge/bin/files migrate: Get no strlen() error anymore but only expected output Usage Exception: Specify an engine to migrate to with --engine`. Use files engines to get a list of engines.`

Diff Detail

Repository
rP Phorge
Branch
cliFilesMigrateStrlen (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1186
Build 1186: arc lint + arc unit