Paths

Table of Contentst

Correct docs of PhabricatorPHIDType::getAllTypesForApplication()
ClosedPublic
Actions

Authored by aklapper on Apr 7 2024, 20:00.

Tags

None

Referenced Files

	F3340142: D25572.1743631907.diff
	Tue, Apr 1, 22:11

	F3334137: D25572.1743545454.diff
	Mon, Mar 31, 22:10

	F3332012: D25572.1743517557.diff
	Mon, Mar 31, 14:25

	F3331713: D25572.1743511397.diff
	Mon, Mar 31, 12:43

	F3331710: D25572.1743511390.diff
	Mon, Mar 31, 12:43

	F3329688: D25572.1743478991.diff
	Mon, Mar 31, 03:43

	F3328647: D25572.1743459695.diff
	Sun, Mar 30, 22:21

	F3321845: D25572.1743361984.diff
	Sat, Mar 29, 19:13

Subscribers

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Commits

rP5a5c456264af: Correct docs of PhabricatorPHIDType::getAllTypesForApplication()

Summary

The signature and return type of the getAllTypesForApplication() function differed from its docs.

Test Plan

Carefully read the code of the function and compare it to the getAllInstalledTypes() function above from which the docs were incorrectly copied.

Diff Detail

Repository

rP Phorge

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aklapper created this revision.Apr 7 2024, 20:00

Owners added a reviewer: O1: Blessed Committers.Apr 7 2024, 20:00

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptApr 7 2024, 20:00

aklapper requested review of this revision.Apr 7 2024, 20:00

Harbormaster completed remote builds in B1156: Diff 1829.Apr 7 2024, 20:00

yesyes

This revision is now accepted and ready to land.Apr 7 2024, 21:01

Closed by commit rP5a5c456264af: Correct docs of PhabricatorPHIDType::getAllTypesForApplication(). · Explain WhyApr 8 2024, 11:14

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rP5a5c456264af: Correct docs of PhabricatorPHIDType::getAllTypesForApplication().

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

phid/

type/

PhabricatorPHIDType.php

7 lines

O1: Blessed Committers

Diff 1831

View Options

src/applications/phid/type/PhabricatorPHIDType.php

Correct docs of PhabricatorPHIDType::getAllTypesForApplication()ClosedPublicActions