Page MenuHomePhorge

Show rest of task page when graph errors out
ClosedPublic

Authored by avivey on Apr 5 2024, 07:33.

Details

Summary
Test Plan

Add a throw statement in graph calculation, load a task that has a graph, see message.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

avivey requested review of this revision.Apr 5 2024, 07:33

sgtm

Thanks. Tested this in a correct situation and also causing a crash putting an unset($nodes[$current_node]) in ../arcanist/src/utils/AbstractDirectedGraph.php to see the nice exception message

This revision is now accepted and ready to land.Apr 5 2024, 08:42