Paths

Table of Contentst

Show rest of task page when graph errors out
ClosedPublic
Actions

Authored by avivey on Apr 5 2024, 07:33.

Tags

None

Referenced Files

	F3605084: D25570.1745251522.diff
	Sun, Apr 20, 16:05

	F3604644: D25570.1745218358.diff
	Sun, Apr 20, 06:52

	F3586721: D25570.1745136308.diff
	Sat, Apr 19, 08:05

	F3577472: D25570.1745086747.diff
	Fri, Apr 18, 18:19

	F3576034: D25570.1745021851.diff
	Fri, Apr 18, 00:17

	F3528459: D25570.1744851375.diff
	Wed, Apr 16, 00:56

	F3450718: D25570.1744713769.diff
	Mon, Apr 14, 10:42

	F3372319: D25570.1744249508.diff
	Wed, Apr 9, 01:45

Subscribers

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Commits

rPecbef3fdf4b6: Show rest of task page when graph errors out

Summary

T15772.

Test Plan

Add a throw statement in graph calculation, load a task that has a graph, see message.

Diff Detail

Repository

rP Phorge

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1154
Build 1154: arc lint + arc unit

Event Timeline

avivey created this revision.Apr 5 2024, 07:33

Owners added a reviewer: O1: Blessed Committers.Apr 5 2024, 07:33

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptApr 5 2024, 07:33

avivey requested review of this revision.Apr 5 2024, 07:33

Harbormaster completed remote builds in B1154: Diff 1826.Apr 5 2024, 07:33

sgtm

Thanks. Tested this in a correct situation and also causing a crash putting an unset($nodes[$current_node]) in ../arcanist/src/utils/AbstractDirectedGraph.php to see the nice exception message

This revision is now accepted and ready to land.Apr 5 2024, 08:42

Closed by commit rPecbef3fdf4b6: Show rest of task page when graph errors out. · Explain WhyApr 5 2024, 10:26

This revision was automatically updated to reflect the committed changes.

avivey added a commit: rPecbef3fdf4b6: Show rest of task page when graph errors out.

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

maniphest/

controller/

ManiphestTaskDetailController.php

23 lines

O1: Blessed Committers

Diff 1826

View Options

src/applications/maniphest/controller/ManiphestTaskDetailController.php

Show rest of task page when graph errors outClosedPublicActions