Page MenuHomePhorge

Show rest of task page when graph errors out
ClosedPublic

Authored by avivey on Apr 5 2024, 07:33.
Tags
None
Referenced Files
F2992934: D25570.1740261098.diff
Fri, Feb 21, 21:51
F2990718: D25570.1740180028.diff
Thu, Feb 20, 23:20
F2990717: D25570.1740179982.diff
Thu, Feb 20, 23:19
F2990387: D25570.1740177770.diff
Thu, Feb 20, 22:42
F2977932: D25570.1739659775.diff
Fri, Feb 14, 22:49
F2977931: D25570.1739659774.diff
Fri, Feb 14, 22:49
F2977922: D25570.1739659112.diff
Fri, Feb 14, 22:38
F2977917: D25570.1739658052.diff
Fri, Feb 14, 22:20

Details

Summary
Test Plan

Add a throw statement in graph calculation, load a task that has a graph, see message.

Diff Detail

Repository
rP Phorge
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 1154
Build 1154: arc lint + arc unit

Event Timeline

avivey requested review of this revision.Apr 5 2024, 07:33

sgtm

Thanks. Tested this in a correct situation and also causing a crash putting an unset($nodes[$current_node]) in ../arcanist/src/utils/AbstractDirectedGraph.php to see the nice exception message

This revision is now accepted and ready to land.Apr 5 2024, 08:42