Paths

Table of Contentst

Differential D25567

Fix PHP 8.1 "preg_match(null)" exception exporting task list to CSV
ClosedPublic
Actions

Authored by aklapper on Apr 2 2024, 20:31.

Tags

None

Referenced Files

	F3346560: D25567.1743704668.diff
	Wed, Apr 2, 18:24

	F3337196: D25567.1743586151.diff
	Tue, Apr 1, 09:29

	F3328798: D25567.1743462267.diff
	Sun, Mar 30, 23:04

	F3322869: D25567.1743379782.diff
	Sun, Mar 30, 00:09

	F3312816: D25567.1743213617.diff
	Fri, Mar 28, 02:00

	F3310235: D25567.1743193578.diff
	Thu, Mar 27, 20:26

	F3300577: D25567.1743042088.diff
	Wed, Mar 26, 02:21

	F3295733: D25567.1742960982.diff
	Tue, Mar 25, 03:49

View All 41 Files

Subscribers

valerio.bozzolan

Details

Reviewers

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15770: PHP 8.1 "preg_match(null)" exception exporting task list to CSV

Commits

rPc0bc45340584: Fix PHP 8.1 "preg_match(null)" exception exporting task list to CSV

Summary

When a column value to export to CSV is empty, null is passed to preg_match() which is deprecated behavior since PHP 8.1.
Thus only call preg_match() when the value is set.

ERROR 8192: preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated at [/var/www/html/phorge/phorge/src/infrastructure/export/format/PhabricatorCSVExportFormat.php:51]

ERROR 8192: preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated at [/var/www/html/phorge/phorge/src/infrastructure/export/format/PhabricatorCSVExportFormat.php:55]

Closes T15770

Test Plan

Export a Maniphest task list of query results to CSV.

Diff Detail

Repository

Branch

csvExport (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1142
Build 1142: arc lint + arc unit

Event Timeline

aklapper created this revision.Apr 2 2024, 20:31

Owners added a reviewer: O1: Blessed Committers.Apr 2 2024, 20:31

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptApr 2 2024, 20:31

aklapper requested review of this revision.Apr 2 2024, 20:31

Harbormaster completed remote builds in B1142: Diff 1811.Apr 2 2024, 20:31

20after4 accepted this revision.Apr 3 2024, 00:50

This revision is now accepted and ready to land.Apr 3 2024, 00:50

Closed by commit rPc0bc45340584: Fix PHP 8.1 "preg_match(null)" exception exporting task list to CSV. · Explain WhyApr 3 2024, 09:57

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rPc0bc45340584: Fix PHP 8.1 "preg_match(null)" exception exporting task list to CSV.

Revision Contents
Changeset List

Path

Size

Packages

src/

infrastructure/

export/

format/

PhabricatorCSVExportFormat.php

4 lines

O1: Blessed Committers

Diff 1811

src/infrastructure/export/format/PhabricatorCSVExportFormat.php

Loading...