- Properly handle when no mail headers at all can be parsed
- Properly handle when mail headers can be parsed but no subject line can be found
EXCEPTION: (RuntimeException) Undefined index: subject
Closes T15769
Details
Details
- Reviewers
valerio.bozzolan - Group Reviewers
O1: Blessed Committers - Maniphest Tasks
- T15769: Make handling incoming mail a bit more robust/correct
- Commits
- rP644f179dd27a: Make incoming mail handling more robust / correct
See T15769
Diff Detail
Diff Detail
- Repository
- rP Phorge
- Branch
- MoreMimeMailParserPeouw (branched from master)
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 1135 Build 1135: arc lint + arc unit
Event Timeline
| externals/mimemailparser/MimeMailParser.class.php | ||
|---|---|---|
| 317 | This is becoming a bit hacky now, since false is probably never returned anymore. Maybe moving this exception to the consumer? I mean throwing in line 57 of mail_handler.php | |
| externals/mimemailparser/MimeMailParser.class.php | ||
|---|---|---|
| 317 | In my understanding the return value false was not handled anywhere anyway, so I didn't mind. I was after throwing a correct error message instead of failing way later with a misleading error message. :) | |
| externals/mimemailparser/MimeMailParser.class.php | ||
|---|---|---|
| 310–317 |
should it be like this then? | |
Comment Actions
FTR I gave this last version another test locally, feeding an mbox file with no subject header (which is accepted now without complaints), and bugging input again (which prints a correct error message instead of misleadingly complaining about a missing subject line)