Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception when received email lacks From header
ClosedPublic

Authored by aklapper on Mar 31 2024, 11:54.
Tags
None
Referenced Files
F3215754: D25564.1741660616.diff
Mon, Mar 10, 02:36
F3005891: D25564.1740548127.diff
Tue, Feb 25, 05:35
F3001465: D25564.1740442154.diff
Mon, Feb 24, 00:09
F3001464: D25564.1740442154.diff
Mon, Feb 24, 00:09
F2987209: D25564.1740110762.diff
Thu, Feb 20, 04:06
F2982264: D25564.1739948780.diff
Tue, Feb 18, 07:06
F2980895: D25564.1739907037.diff
Mon, Feb 17, 19:30
F2976915: D25564.1739593101.diff
Fri, Feb 14, 04:18

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/metamta/storage/PhabricatorMetaMTAReceivedMail.php:527]

Closes T15767

Test Plan

See T15767

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable