Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception when received email lacks From header
ClosedPublic

Authored by aklapper on Mar 31 2024, 11:54.
Tags
None
Referenced Files
F3334468: D25564.1743549600.diff
Mon, Mar 31, 23:20
F3334052: D25564.1743544024.diff
Mon, Mar 31, 21:47
F3328930: D25564.1743465696.diff
Mon, Mar 31, 00:01
F3321934: D25564.1743363133.diff
Sat, Mar 29, 19:32
F3319558: D25564.1743310350.diff
Sat, Mar 29, 04:52
F3318084: D25564.1743274262.diff
Fri, Mar 28, 18:51
F3312700: D25564.1743213249.diff
Fri, Mar 28, 01:54
F3309383: D25564.1743184202.diff
Thu, Mar 27, 17:50

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/metamta/storage/PhabricatorMetaMTAReceivedMail.php:527]

Closes T15767

Test Plan

See T15767

Diff Detail

Repository
rP Phorge
Branch
T15767noFromEmail (branched from master)
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 1133
Build 1133: arc lint + arc unit