Page MenuHomePhorge
Differential D25563

Fix "Creation of dynamic property is deprecated" PHP 8.2 error in MimeMailParser
ClosedPublic
Actions

Authored by aklapper on Mar 29 2024, 11:36.

Details

Reviewers
avivey
Group Reviewers
O1: Blessed Committers
Maniphest Tasks
T15765: PHP 8.2 error: "Creation of dynamic property MimeMailParser::$parts is deprecated"
Commits
rPa69db10c5e15: Fix "Creation of dynamic property is deprecated" PHP 8.2 error in MimeMailParser
Summary

Add #[AllowDynamicProperties] attribute to avoid the deprecation notice.

See https://php.watch/versions/8.2/dynamic-properties-deprecated

# ERROR 8192: Creation of dynamic property MimeMailParser::$parts is deprecated at [/var/www/html/phorge/phorge/externals/mimemailparser/MimeMailParser.class.php:137]
#  #0 MimeMailParser::parse() called at [<phorge>/externals/mimemailparser/MimeMailParser.class.php:126]

Closes T15765

Test Plan

See T15765

Diff Detail

Repository
rP Phorge
Branch
arcpatch-D25563
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 1132
Build 1132: arc lint + arc unit

Event Timeline

aklapper created this revision.Mar 29 2024, 11:36
Owners added a reviewer: O1: Blessed Committers.Mar 29 2024, 11:37
Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptMar 29 2024, 11:37
aklapper requested review of this revision.Mar 29 2024, 11:37
Harbormaster completed remote builds in B1130: Diff 1793.Mar 29 2024, 11:37
avivey subscribed.Mar 29 2024, 12:07

Can we just define the used properties instead? Doesn't look like there's too many of them.

valerio.bozzolan added a comment.Mar 29 2024, 13:11

I agree and I'm quite sure that just parts is missing

externals/mimemailparser/MimeMailParser.class.php
438

Unrelated but this legacy part is weird. Maybe:

$encoding = array_key_exists('content-transfer-encoding', $part['headers'])
  ? $part['headers']['content-transfer-encoding']
  : '';
489

Unrelated but we may want to remove this ending ?> since it's good practice to avoid that if we have not output after that.

valerio.bozzolan mentioned this in T15766: Cleanup a bit MimeMailParser.Mar 29 2024, 13:20

Plenty of creative scope for a follow-up Diff - T15766

externals/mimemailparser/MimeMailParser.class.php
92

Unrelated but this return is never reached 🤔

120

Unrelated but this is not indented correctly ↑

aklapper updated this revision to Diff 1795.Mar 31 2024, 08:35
In D25563#16157, @avivey wrote:

Can we just define the used properties instead? Doesn't look like there's too many of them.

Is that really as trivial as in my last revision? Sorry, still considering myself a PHP newbie, plus this codebase seems to be quite bitrotting.

FYI:

  • For debugging, at the end of function parse() in MimeMailParser.class.php I added phlog(pht(json_encode(mailparse_msg_get_part_data($part))));.
  • While playing with the code I did sometimes get an unexpectedly empty "headers":[] in the $part, leading later to (RuntimeException) Undefined index: subject, but failed to properly reproduce so far.
Harbormaster completed remote builds in B1131: Diff 1795.Mar 31 2024, 08:35
aklapper updated this revision to Diff 1796.Mar 31 2024, 08:42

and now for real, without #[\AllowDynamicProperties]

Harbormaster completed remote builds in B1132: Diff 1796.Mar 31 2024, 08:42
avivey added a comment.Mar 31 2024, 08:46

Is that really as trivial as in my last revision?

Yeah, pretty much.

externals/mimemailparser/MimeMailParser.class.php
37

we don't like [] for array initialization - use array().

137

Maybe keep this, just to make sure we don't leak anything across executions

aklapper updated this revision to Diff 1798.Mar 31 2024, 12:01

Correct array initialization; keep line in parse().

Tested again locally; still works as expected for this very task.

Harbormaster completed remote builds in B1134: Diff 1798.Mar 31 2024, 12:01
aklapper marked 2 inline comments as done.Mar 31 2024, 12:02
avivey accepted this revision.Mar 31 2024, 12:17

:-)

This revision is now accepted and ready to land.Mar 31 2024, 12:17
Closed by commit rPa69db10c5e15: Fix "Creation of dynamic property is deprecated" PHP 8.2 error in MimeMailParser. · Explain WhyMar 31 2024, 13:25
This revision was automatically updated to reflect the committed changes.
aklapper added a commit: rPa69db10c5e15: Fix "Creation of dynamic property is deprecated" PHP 8.2 error in MimeMailParser.
valerio.bozzolan added a comment.Mar 31 2024, 14:07

(Whops! wrong summary)

externals/mimemailparser/MimeMailParser.class.php
464

Unrelated but unreachable return

aklapper added a comment.Mar 31 2024, 16:12

Argh, sorry!

Revision Contents
Changeset List

PathSizePackages
externals/
mimemailparser/
6 linesO1: Blessed Committers

Diff 1796

View Options

externals/mimemailparser/MimeMailParser.class.php

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0