Show All 29 Lines	$file = id(new PhabricatorFileQuery())
->withPHIDs(array($file_phid))		->withPHIDs(array($file_phid))
->executeOne();		->executeOne();
if (!$file) {		if (!$file) {
return new Aphront404Response();		return new Aphront404Response();
}		}

$xactions = array();		$xactions = array();

		// Set the Image Cover.
$xactions[] = id(new ManiphestTransaction())		$xactions[] = id(new ManiphestTransaction())
->setTransactionType(ManiphestTaskCoverImageTransaction::TRANSACTIONTYPE)		->setTransactionType(ManiphestTaskCoverImageTransaction::TRANSACTIONTYPE)
->setNewValue($file->getPHID());		->setNewValue($file->getPHID());

		// Attach the Cover Image to the Task.
		// Base case: handling a new file (supported):
		// If you are the author of the new File, that File is probably private
		// as default, so, you attach, to make it visible to Task participants.
		// Future case: already-existing file (currently unsupported):
		// If you are the author of an already-existing file, that may be
		// already attached to this Object.
		// This is currently not supported from the UX but may be supported
		// later, checking for potential errors related to double-attach.
		// Unknown future cases:
		// A non-author may want to attach a semi-private already-existing file
		// to make it somehow "more visible" than before without authorization
		// from the original author.
		// It is probably quite foolish to try to prevent this kind of things,
		// since, if you can see something, indeed you can copy-pasta that.
		// Anyway, since this use-case is unknown,
		// we are a bit strict, requiring to be the author of that file,
		// before sharing that as Task cover image.
		// If you want to support this, and omit this check, join the Task :)
		// https://we.phorge.it/T15163
		if ($file->getAuthorPHID() === $viewer->getPHID()) {
		$template = $object->getApplicationTransactionTemplate();
		$attach_mode = PhabricatorFileAttachment::MODE_ATTACH;
		$xactions[] = id(clone $template)
		->setTransactionType(PhabricatorTransactions::TYPE_FILE)
		->setNewValue(
		array(
		$file_phid => $attach_mode,
		));
		}

		valerio.bozzolanAuthorUnsubmitted Done Inline Actions Probably, this could also be done inside an `expandTransaction` method in `ManiphestTransactionEditor`. But I'm not bold enough to generalize this. Thanks for tips. valerio.bozzolan: Probably, this could also be done inside an `expandTransaction` method in…
$editor = id(new ManiphestTransactionEditor())		$editor = id(new ManiphestTransactionEditor())
->setActor($viewer)		->setActor($viewer)
->setContinueOnMissingFields(true)		->setContinueOnMissingFields(true)
->setContinueOnNoEffect(true)		->setContinueOnNoEffect(true)
->setContentSourceFromRequest($request);		->setContentSourceFromRequest($request);

$editor->applyTransactions($object, $xactions);		$editor->applyTransactions($object, $xactions);

return $this->newCardResponse($board_phid, $object_phid);		return $this->newCardResponse($board_phid, $object_phid);
}		}

}		}

Update unit test of InterpreterBlockRule for "a {{{a}}}"ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 1779

src/infrastructure/markup/remarkup/__tests__/remarkup/interpreter-test.txt

Update unit test of InterpreterBlockRule for "a {{{a}}}"
ClosedPublic
Actions

Revision Contents
Changeset List

src/infrastructure/markup/remarkup/tests/remarkup/interpreter-test.txt