Update unit test of InterpreterBlockRule for "a {{{a}}}"
ClosedPublic
Actions

Authored by valerio.bozzolan on Mar 25 2024, 07:18.

Details

Reviewers

Group Reviewers

Maniphest Tasks

T15372: "RuntimeException: Undefined array key" when pasting "a {{{a}}} a" comment (due to regex in PhutilRemarkupInterpreterBlockRule.php)

Commits

rP9ebe85621919: Update unit test of InterpreterBlockRule for "a {{{a}}}"

Summary

This is supposed to render in plain text instead of crashing or giving an error, after D25415:

a {{{a}}}

The related unit test is updated accordingly.

We have unnoticed this, because of the well-known bug T15500.

Ref T15372
See D25415

Test Plan

This makes sense with the introduced functionality in D25415.

Unit tests are happy again.

Diff Detail

Repository

rP Phorge

Branch

D25415-update-unit-test

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1120
Build 1120: arc lint + arc unit

Event Timeline

valerio.bozzolan created this revision.Mar 25 2024, 07:18

Owners added a reviewer: O1: Blessed Committers.Mar 25 2024, 07:18

Herald added subscribers: Cigaryno, Matthew, tobiaswiese. · View Herald TranscriptMar 25 2024, 07:18

valerio.bozzolan requested review of this revision.Mar 25 2024, 07:18

Harbormaster completed remote builds in B1120: Diff 1778.Mar 25 2024, 07:18

remove unrelated stuff

Harbormaster completed remote builds in B1121: Diff 1779.Mar 25 2024, 07:20

valerio.bozzolan added a child revision: D25560: Remarkup code blocks: guess language from "name=".Mar 25 2024, 07:43

avivey accepted this revision.Mar 25 2024, 08:27

This revision is now accepted and ready to land.Mar 25 2024, 08:27

Closed by commit rP9ebe85621919: Update unit test of InterpreterBlockRule for "a {{{a}}}". · Explain WhyMar 25 2024, 08:28

This revision was automatically updated to reflect the committed changes.

valerio.bozzolan added a commit: rP9ebe85621919: Update unit test of InterpreterBlockRule for "a {{{a}}}".

valerio.bozzolan mentioned this in D25540: Add PhutilRemarkupHexColorCodeRule, a new remarkup rule to format color codes.Mar 28 2024, 08:54

Revision Contents
Changeset List

Path

Size

Packages

src/

infrastructure/

markup/

blockrule/

PhutilRemarkupCodeBlockRule.php

19 lines

O1: Blessed Committers

remarkup/

__tests__/

remarkup/

interpreter-test.txt

8 lines

O1: Blessed Committers

Diff 1778

View Options

src/infrastructure/markup/blockrule/PhutilRemarkupCodeBlockRule.php

View Options

src/infrastructure/markup/remarkup/tests/remarkup/interpreter-test.txt

Update unit test of InterpreterBlockRule for "a {{{a}}}"ClosedPublicActions