Differential D25525
Improve messages when no image formats are supported (due to GD not installed) Authored by aklapper on Jan 24 2024, 10:15. Tags None Referenced Files
Subscribers
Details When GD is not installed, trying to set a custom image for a project/blog/repository/user/etc displays unhelpful error messages (This server only supports these image formats: . and Supported formats: ) due to the array of supported image formats being empty. Display clearer messages instead. Closes T15720 Do not have php-gd installed, go to /project/manage/1/, take a look at the string below the "Upload Picture" button, select Edit Picture in the sidebar, select Custom: Choose Icon and Color..., Choose Background Color and Choose Icon, then click the Save Image button. Also try to upload a custom image and look at the error message.
Diff Detail
Event TimelineComment Actions I super-like the result of this in /project/manage/1/, so approved. Bonus points: Maybe simplify if (empty($v)) { to just if ($v) { and swapping the case https://www.php.net/manual/en/language.types.boolean.php#language.types.boolean.casting Comment Actions Ahem, such comments always make me realize how my brain structure isn't necessarily a simplicity role model. :P |