Improve messages when no image formats are supported (due to GD not installed)
ClosedPublic
Actions

Authored by aklapper on Jan 24 2024, 10:15.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15720: Improve messages when no image formats are supported (due to GD not installed)

Commits

rPe2bec4c1f58b: Improve messages when no image formats are supported (due to GD not installed)

Summary

When GD is not installed, trying to set a custom image for a project/blog/repository/user/etc displays unhelpful error messages (This server only supports these image formats: . and Supported formats: ) due to the array of supported image formats being empty.

Display clearer messages instead.

Closes T15720

Test Plan

Do not have php-gd installed, go to /project/manage/1/, take a look at the string below the "Upload Picture" button, select Edit Picture in the sidebar, select Custom: Choose Icon and Color..., Choose Background Color and Choose Icon, then click the Save Image button. Also try to upload a custom image and look at the error message.

Diff Detail

Repository

rP Phorge

Branch

noImgFormatsNoCry (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1057
Build 1057: arc lint + arc unit

Event Timeline

aklapper created this revision.Jan 24 2024, 10:15

Owners added a reviewer: O1: Blessed Committers.Jan 24 2024, 10:15

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptJan 24 2024, 10:15

aklapper requested review of this revision.Jan 24 2024, 10:15

Harbormaster completed remote builds in B1042: Diff 1663.Jan 24 2024, 10:15

aklapper mentioned this in T15720: Improve messages when no image formats are supported (due to GD not installed).Jan 24 2024, 10:16

I super-like the result of this in /project/manage/1/, so approved.

Bonus points:

Maybe simplify if (empty($v)) { to just if ($v) { and swapping the case

https://www.php.net/manual/en/language.types.boolean.php#language.types.boolean.casting

This revision is now accepted and ready to land.Feb 12 2024, 10:38

In D25525#15322, @valerio.bozzolan wrote:

Maybe simplify if (empty($v)) { to just if ($v) { and swapping the case

Ahem, such comments always make me realize how my brain structure isn't necessarily a simplicity role model. :P
Yes, doing so in the next revision. Thanks!

Make code more readable

Harbormaster completed remote builds in B1057: Diff 1693.Feb 12 2024, 11:01

Closed by commit rPe2bec4c1f58b: Improve messages when no image formats are supported (due to GD not installed). · Explain WhyFeb 13 2024, 16:07

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rPe2bec4c1f58b: Improve messages when no image formats are supported (due to GD not installed).