I've read your awesome travel in T15659 but I've also read this inline comment:

// TODO: Once everything is on EditEngine, just use getIsNewObject()

So maybe this? but I'm not bold enough:

$mark_as_create = $this->getIsNewObject();
...

So maybe this?

$mark_as_create = false;
if ($this->getIsNewObject()) {
  $mark_as_create = true;
}
...

In any case, if it works, the rest of the code could be moved inside a private function guessIsNewObject() or similar.

If it works, we need to probably expand a bit the test plan

In an ideal world 1030-1313 could become just:

$mark_as_create = $this->getIsNewObject() || $this->guessIsNewObject();

In D25517#14977, @valerio.bozzolan wrote:

// TODO: Once everything is on EditEngine, just use getIsNewObject()

So maybe this? but I'm not bold enough:

Me neither currently. :) Could be a nice followup project to try and test extensively...?

maybe

if ($this->getIsNewObject() || $xaction->getTransactionType == ...)

?
Then it only needs to be tested in the one case, and we can avoid code creeping from Differential here.

edit - oh, it was already suggested :)

In D25517#14978, @valerio.bozzolan wrote:

In an ideal world 1030-1313 could become just:

I think you're off with the line numbers?

(Not sure I can entirely follow the last comments - if somebody wants to push another revision, please feel very welcome to.)

The more I look at the code, the less I understand the comment about "just use getIsNewObject()".

I'm gonna counter-diff with setting the IsCreate in the CreteRawDiff conduit class, which is just a pile of hack anyway.

@avivey Much cleaner and also works as expected (just tested). Thanks for finding that better approach! Now how can I approve your patch as I'm still set as original author, sigh?