T15064: Several arcanist PHP 8.1 compat issues on Windows
ClosedPublic
Actions

Authored by speck on Feb 6 2024, 00:37.

Details

Reviewers

avivey

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15064: Make Phorge compatible with PHP 8.1/8.2/8.3

Commits

rARC8ef1ead6aca0: T15064: Several arcanist PHP 8.1 compat issues on Windows

Summary

Ran into strlen/strpos issues while using Arcanist on Windows:

Running arc version when not in a project/repository directory blew up (may not be specific to Windows).
Determining mime type of binary file in repository fails.

Refs T15064

Test Plan

Ran diff including a binary file. Ran arc version when not in a project/repository directory.

Diff Detail

Repository

rARC Arcanist

Branch

arcwin

Lint

Lint Skipped

Unit

Test Failures

Build Status

Buildable 1053
Build 1053: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	26 ms	FileFinderTestCase::testFinderWithChecksums EXCEPTION (CommandException): Command failed with error #1! COMMAND find . "(" -path ./exclude -o -path subdir.txt ")" -prune -o -type f "(" -name .txt ")" "(" -path ")" -print0
	15 ms	FileFinderTestCase::testFinderWithDirectories EXCEPTION (CommandException): Command failed with error #1! COMMAND find . "(" -path ./exclude -o -path subdir.txt ")" -prune -o -type d -print0
	19 ms	FileFinderTestCase::testFinderWithFilesAndDirectories EXCEPTION (CommandException): Command failed with error #1! COMMAND find . "(" -path ./exclude -o -path subdir.txt ")" -prune -o "(" -name .txt ")" "(" -path ")" -print0
	19 ms	FileFinderTestCase::testFinderWithNameAndSuffix EXCEPTION (CommandException): Command failed with error #1! COMMAND find . "(" -path ./exclude -o -path subdir.txt ")" -prune -o -type f "(" -name alsoinclude.txt ")" "(" -name *.txt ")" -print0
	24 ms	FileFinderTestCase::testFinderWithNames EXCEPTION (CommandException): Command failed with error #1! COMMAND find . "(" -path ./exclude -o -path subdir.txt ")" -prune -o -type f "(" -name test ")" "(" -path * ")" -print0
		View Full Test Results (9 Failed · 22 Passed · 1 Skipped)

Event Timeline

speck created this revision.Feb 6 2024, 00:37

Owners added a reviewer: O1: Blessed Committers.Feb 6 2024, 00:37

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptFeb 6 2024, 00:37

speck requested review of this revision.Feb 6 2024, 00:37

Harbormaster completed remote builds in B1053: Diff 1684.Feb 6 2024, 00:38

I wonder how many Windows users we have. The xhpast linter does not work, and the unit test failures listed here are pre-existing and occur without these changes.

speck edited the summary of this revision. (Show Details)Feb 6 2024, 03:42

speck added a task: T15064: Make Phorge compatible with PHP 8.1/8.2/8.3.

To be fair, it's possible that most of the arc features work for Windows users that don't use PHP. Or at least, arc diff might work for some setup of lint/unit configuration.

This revision is now accepted and ready to land.Feb 6 2024, 09:23

Both of these failures are edge cases so it does seem likely we wouldn't have found them as quickly. I do still wonder how many Windows users we have.

This revision was landed with ongoing or failed builds.Feb 6 2024, 11:56

Closed by commit rARC8ef1ead6aca0: T15064: Several arcanist PHP 8.1 compat issues on Windows. · Explain Why

This revision was automatically updated to reflect the committed changes.

speck added a commit: rARC8ef1ead6aca0: T15064: Several arcanist PHP 8.1 compat issues on Windows.