Ran into strlen/strpos issues while using Arcanist on Windows:
- Running arc version when not in a project/repository directory blew up (may not be specific to Windows).
- Determining mime type of binary file in repository fails.
Refs T15064
Details
Details
- Reviewers
avivey - Group Reviewers
O1: Blessed Committers - Maniphest Tasks
- T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4
- Commits
- rARC8ef1ead6aca0: T15064: Several arcanist PHP 8.1 compat issues on Windows
Ran diff including a binary file. Ran arc version when not in a project/repository directory.
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Branch
- arcwin
- Lint
Lint Skipped - Unit
Test Failures - Build Status
Buildable 1053 Build 1053: arc lint + arc unit
| Time | Test | |
|---|---|---|
| 26 ms | FileFinderTestCase::testFinderWithChecksums EXCEPTION (CommandException): Command failed with error #1!
COMMAND
find . "(" -path ./exclude -o -path subdir.txt ")" -prune -o -type f "(" -name *.txt ")" "(" -path * ")" -print0
| |
| 15 ms | FileFinderTestCase::testFinderWithDirectories EXCEPTION (CommandException): Command failed with error #1!
COMMAND
find . "(" -path ./exclude -o -path subdir.txt ")" -prune -o -type d -print0
| |
| 19 ms | FileFinderTestCase::testFinderWithFilesAndDirectories EXCEPTION (CommandException): Command failed with error #1!
COMMAND
find . "(" -path ./exclude -o -path subdir.txt ")" -prune -o "(" -name *.txt ")" "(" -path * ")" -print0
| |
| 19 ms | FileFinderTestCase::testFinderWithNameAndSuffix EXCEPTION (CommandException): Command failed with error #1!
COMMAND
find . "(" -path ./exclude -o -path subdir.txt ")" -prune -o -type f "(" -name alsoinclude.txt ")" "(" -name *.txt ")" -print0
| |
| 24 ms | FileFinderTestCase::testFinderWithNames EXCEPTION (CommandException): Command failed with error #1!
COMMAND
find . "(" -path ./exclude -o -path subdir.txt ")" -prune -o -type f "(" -name test ")" "(" -path * ")" -print0
| |
| View Full Test Results (9 Failed · 22 Passed · 1 Skipped) |
Event Timeline
Comment Actions
I wonder how many Windows users we have. The xhpast linter does not work, and the unit test failures listed here are pre-existing and occur without these changes.
Comment Actions
To be fair, it's possible that most of the arc features work for Windows users that don't use PHP. Or at least, arc diff might work for some setup of lint/unit configuration.
Comment Actions
Both of these failures are edge cases so it does seem likely we wouldn't have found them as quickly. I do still wonder how many Windows users we have.