This is exactly the same as I've done on the system I patched at my workplace. I apologize for not submitting my own patch, I didn't have access to my work systems during the holidays.

valerio.bozzolan mentioned this in Q96: Support for FIDO2-backed SSH keys (Answer 129).Jan 8 2024, 13:14

notmyfault

This revision is now accepted and ready to land.Jan 8 2024, 14:28

Closed by commit rP6fe942a8f9f6: Add support for FIDO2-backed SSH keys. · Explain WhyJan 8 2024, 18:08

This revision was automatically updated to reflect the committed changes.

valerio.bozzolan added a commit: rP6fe942a8f9f6: Add support for FIDO2-backed SSH keys.

valerio.bozzolan mentioned this in Next Up.Jan 8 2024, 18:08

avivey mentioned this in 2024 week 19.May 11 2024, 04:37

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

auth/

sshkey/

PhabricatorAuthSSHPublicKey.php

4 lines

O1: Blessed Committers

Diff 1616

View Options

src/applications/auth/sshkey/PhabricatorAuthSSHPublicKey.php

Show First 20 Lines • Show All 290 Lines • ▼ Show 20 Lines $comment_box = id(new PHUIObjectBoxView())

->appendChild($comment); ->appendChild($comment);

return array($comment_box, $preview); return array($comment_box, $preview);

} }

private function renderCommentPanel() { private function renderCommentPanel() {

$viewer = $this->getViewer(); $viewer = $this->getViewer();

// Set a placeholder text in the comment field defined via

// getCommentFieldPlaceholderText() in the object's EditEngine class

$placeholder_text = '';

$object_phid = $this->getObjectPHID();

aviveyUnsubmitted

Done

method_exists can be replaced with a concrete method in the base class.

avivey: `method_exists` can be replaced with a concrete method in the base class.

$phid_types = mpull(PhabricatorPHIDType::getAllInstalledTypes($viewer),

valerio.bozzolanUnsubmitted

Done

$query = id(new ManiphestTaskQuery())

- ->setViewer(PhabricatorUser::getOmnipotentUser())

+ ->setViewer($viewer)

->needSubscriberPHIDs(false)

Have you already tried this?

valerio.bozzolan: Have you already tried this?

null, 'getTypeConstant');

$object_type = idx($phid_types, phid_get_type($object_phid));

// Find matching EditEngine for our object via ApplicationClasses

if ($object_type) {

$app_class = $object_type->getPHIDTypeApplicationClass();

$engines = id(new PhabricatorEditEngineQuery())

->setViewer($this->getViewer())

->execute();

$engines = mpull($engines, null, 'getEngineApplicationClass');

$engine = idx($engines, $app_class);

$engine_class = get_class($engine);

if (method_exists($engine_class, 'getCommentFieldPlaceholderText')) {

$placeholder_text =

$engine->getCommentFieldPlaceholderText($object_phid);

}

$remarkup_control = id(new PhabricatorRemarkupControl()) $remarkup_control = id(new PhabricatorRemarkupControl())

->setViewer($viewer) ->setViewer($viewer)

->setID($this->getCommentID()) ->setID($this->getCommentID())

->addClass('phui-comment-fullwidth-control') ->addClass('phui-comment-fullwidth-control')

->addClass('phui-comment-textarea-control') ->addClass('phui-comment-textarea-control')

->setCanPin(true) ->setCanPin(true)

->setPlaceholder($placeholder_text)

->setName('comment'); ->setName('comment');

$draft_comment = ''; $draft_comment = '';

$draft_metadata = array(); $draft_metadata = array();

$draft_key = null; $draft_key = null;

$legacy_draft = $this->getDraft(); $legacy_draft = $this->getDraft();

if ($legacy_draft) { if ($legacy_draft) {

▲ Show 20 Lines • Show All 327 Lines • Show Last 20 Lines

Add support for FIDO2-backed SSH keysClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 1616

src/applications/auth/sshkey/PhabricatorAuthSSHPublicKey.php

Add support for FIDO2-backed SSH keys
ClosedPublic
Actions

Revision Contents
Changeset List