Differential D25508

Add support for FIDO2-backed SSH keys
ClosedPublic
Actions

Authored by valerio.bozzolan on Jan 8 2024, 13:01.

Tags

None

Referenced Files

	F3352723: D25508.1743806886.diff
	Thu, Apr 3, 22:48

	F3352535: D25508.1743800351.diff
	Thu, Apr 3, 20:59

	F3352533: D25508.1743800314.diff
	Thu, Apr 3, 20:58

	F3352532: D25508.1743800281.diff
	Thu, Apr 3, 20:58

	F3343383: D25508.1743679267.diff
	Wed, Apr 2, 11:21

	F3328664: D25508.1743460263.diff
	Sun, Mar 30, 22:31

	F3318266: D25508.1743277408.diff
	Fri, Mar 28, 19:43

	F3301961: D25508.1743059799.diff
	Wed, Mar 26, 07:16

View All 41 Files

Subscribers

Details

Reviewers

antonia
avivey

Group Reviewers

O1: Blessed Committers

Commits

rP6fe942a8f9f6: Add support for FIDO2-backed SSH keys

Summary

U2F/FIDO are open standards for inexpensive two-factor authentication hardware that are widely used for website authentication.

These keys are available since OpenSSH 8.2 (2020-02-14).

https://www.openssh.com/txt/release-8.2

https://security.stackexchange.com/q/240991/260234

Ref Q96

Test Plan

Check the added keys. They exactly match the output of the command 'ssh -Q key'.

Diff Detail

Repository

Branch

fido-tokens

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 1006
Build 1006: arc lint + arc unit

Event Timeline

valerio.bozzolan created this revision.Jan 8 2024, 13:01

Owners added a reviewer: O1: Blessed Committers.Jan 8 2024, 13:01

Herald added subscribers: Cigaryno, Matthew, tobiaswiese. · View Herald TranscriptJan 8 2024, 13:01

valerio.bozzolan requested review of this revision.Jan 8 2024, 13:01

Harbormaster completed remote builds in B1006: Diff 1615.Jan 8 2024, 13:01

valerio.bozzolan added a reviewer: antonia.Jan 8 2024, 13:02

valerio.bozzolan mentioned this in Q96: Support for FIDO2-backed SSH keys.

This is exactly the same as I've done on the system I patched at my workplace. I apologize for not submitting my own patch, I didn't have access to my work systems during the holidays.

valerio.bozzolan mentioned this in Q96: Support for FIDO2-backed SSH keys (Answer 129).Jan 8 2024, 13:14

notmyfault

This revision is now accepted and ready to land.Jan 8 2024, 14:28

Closed by commit rP6fe942a8f9f6: Add support for FIDO2-backed SSH keys. · Explain WhyJan 8 2024, 18:08

This revision was automatically updated to reflect the committed changes.

valerio.bozzolan added a commit: rP6fe942a8f9f6: Add support for FIDO2-backed SSH keys.

valerio.bozzolan mentioned this in Next Up.Jan 8 2024, 18:08

avivey mentioned this in 2024 week 19.May 11 2024, 04:37

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

auth/

sshkey/

PhabricatorAuthSSHPublicKey.php

4 lines

O1: Blessed Committers

Diff 1615

src/applications/auth/sshkey/PhabricatorAuthSSHPublicKey.php

Loading...