Fix PHP 8.1 "strlen(null)" exception when custom select field configured
ClosedPublic
Actions

Authored by aklapper on Dec 6 2023, 19:24.

Details

Reviewers

speck

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15687: PHP 8.1 "strlen(null)" exception when custom select field configured

Commits

rP40d10fbe1ae6: Fix PHP 8.1 "strlen(null)" exception when custom select field configured

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/infrastructure/customfield/standard/PhabricatorStandardCustomField.php:484]

Closes T15687

Test Plan

Unknown. Definitely requires having custom fields defined, then playing with creating tasks using forms which expose these fields and going to /maniphest/query/all/.
See also D25487.

Diff Detail

Repository

rP Phorge

Branch

arcpatch-D25492

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 990
Build 990: arc lint + arc unit

Event Timeline

aklapper created this revision.Dec 6 2023, 19:24

Owners added a reviewer: O1: Blessed Committers.Dec 6 2023, 19:24

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptDec 6 2023, 19:24

aklapper requested review of this revision.Dec 6 2023, 19:24

Harbormaster completed remote builds in B974: Diff 1572.Dec 6 2023, 19:24

It might be safer to do a null check with the strlen check in case the value isn’t a string.

Right, makes sense as I do not fully know the internal logic.
As PhabricatorStandardCustomField is generic, also keep null check type-generic

Harbormaster completed remote builds in B990: Diff 1597.Dec 18 2023, 23:20

The updated one-liner welcomes another review :)

speck accepted this revision.Jan 11 2024, 21:22

speck added inline comments.

src/infrastructure/customfield/standard/PhabricatorStandardCustomField.php
484	I would prefer keeping the strlen check instead of comparing to empty string. I think the effect is the same.

This revision is now accepted and ready to land.Jan 11 2024, 21:22

aklapper added inline comments.Jan 11 2024, 22:32

src/infrastructure/customfield/standard/PhabricatorStandardCustomField.php
484	Hmm, `strlen($field_value)` would return 0 for an empty value, so the difference in behavior would be that we'd still execute `addField` in this case. Probably makes sense, indeed.