Paths

Table of Contentst

Differential D25490

Include 'published' date of posts in Phame Atom feeds
ClosedPublic
Actions

Authored by aklapper on Dec 5 2023, 14:56.

Tags

None

Referenced Files

	F2629753: D25490.1732045337.diff
	Mon, Nov 18, 19:42

	F2628035: D25490.1732011332.diff
	Mon, Nov 18, 10:15

Subscribers

valerio.bozzolan

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15686: Include 'published' date in Phame atom feeds

Commits

rP6c8329fb6614: Include 'published' date of posts in Phame Atom feeds

Summary

Metadata of Phame blog posts includes the 'updated' date of a blog post. Make them also include the original 'published' date.

Patch written by @20after4 from:

https://phabricator.wikimedia.org/rPHAB3de500bfc845759d6da82180df0adfc12f973463

Closes T15686

Test Plan

Go to the Atom feed of blog 1 at /phame/blog/feed/1/ and look at this <feed>'s source
Apply patch and do the same, see additional <published> entry just like the <updated>
Edit the last blog post in blog 1, then check Atom feed and verify that the published and updated date stamp differ as expected

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aklapper created this revision.Dec 5 2023, 14:56

Owners added a reviewer: O1: Blessed Committers.Dec 5 2023, 14:56

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptDec 5 2023, 14:56

aklapper requested review of this revision.Dec 5 2023, 14:56

Harbormaster completed remote builds in B971: Diff 1565.Dec 5 2023, 14:56

If the patch was written by 20after4 we can probably set git commit --amend --author="Mukunda Modell". Can I help in this?

Anyway, tested, thanks!

This revision is now accepted and ready to land.Dec 6 2023, 06:23

valerio.bozzolan edited the summary of this revision. (Show Details)Dec 6 2023, 06:25

valerio.bozzolan edited the test plan for this revision. (Show Details)

git commit --amend --author="Mukunda Modell"

Harbormaster completed remote builds in B975: Diff 1573.Dec 6 2023, 19:33

Closed by commit rP6c8329fb6614: Include 'published' date of posts in Phame Atom feeds. · Explain WhyDec 6 2023, 19:34

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rP6c8329fb6614: Include 'published' date of posts in Phame Atom feeds.

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

phame/

controller/

blog/

PhameBlogFeedController.php

5 lines

O1: Blessed Committers

Diff 1574

src/applications/phame/controller/blog/PhameBlogFeedController.php

Loading...