Differential D25470

Initialize static variable to make linter happy
ClosedPublic
Actions

Authored by • l2dy on Nov 12 2023, 18:21.

Details

Reviewers

speck

Group Reviewers

O1: Blessed Committers

Commits

rP361fcd0cac36: Initialize static variable to make linter happy

Summary

Uninitialized variable defaults to 0 in this context. Make it explicit.

Test Plan

None. No functional change.

Diff Detail

Repository

rP Phorge

Branch

lint/init-static-variable

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 918
Build 918: arc lint + arc unit

Event Timeline

• l2dy created this revision.Nov 12 2023, 18:21

Owners added a reviewer: O1: Blessed Committers.Nov 12 2023, 18:21

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptNov 12 2023, 18:21

• l2dy requested review of this revision.Nov 12 2023, 18:21

Harbormaster completed remote builds in B918: Diff 1489.Nov 12 2023, 18:22

speck accepted this revision.Nov 12 2023, 21:02

This revision is now accepted and ready to land.Nov 12 2023, 21:02

Closed by commit rP361fcd0cac36: Initialize static variable to make linter happy. · Explain WhyNov 13 2023, 00:52

This revision was automatically updated to reflect the committed changes.

• l2dy added a commit: rP361fcd0cac36: Initialize static variable to make linter happy.

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

policy/

filter/

PhabricatorPolicyFilter.php

2 lines

O1: Blessed Committers

Diff 1489

View Options

src/applications/policy/filter/PhabricatorPolicyFilter.php

Initialize static variable to make linter happyClosedPublicActions