Fix PhabricatorAuthCSRFEngine.php strncmp(null) PHP 8.1 error
ClosedPublic
Actions

Authored by Sten on Oct 25 2023, 08:43.

Tags

None

Referenced Files

	F3353834: D25449.1743842602.diff
	Fri, Apr 4, 08:43

	F3352722: D25449.1743806881.diff
	Thu, Apr 3, 22:48

	F3342539: D25449.1743665206.diff
	Wed, Apr 2, 07:26

	F3330905: D25449.1743496872.diff
	Mon, Mar 31, 08:41

	F3310359: D25449.1743194348.diff
	Thu, Mar 27, 20:39

	F3308707: D25449.1743175007.diff
	Thu, Mar 27, 15:16

	F3307730: D25449.1743151270.diff
	Thu, Mar 27, 08:41

	F3306354: D25449.1743127394.diff
	Thu, Mar 27, 02:03

Subscribers

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15654: PhabricatorAuthCSRFEngine.php:50 strncmp(): Passing null to parameter #1 ($string1) of type string is deprecated

Commits

rP318d7a61feab: Fix PhabricatorAuthCSRFEngine.php strncmp(null) PHP 8.1 error

Summary

Update PhabricatorAuthCSRFEngine.php such that it doesn't fall over when provided with a null CSRF token under PHP 8.1

Fixes T15654

Test Plan

Do a POST request to phorge.

Diff Detail

Repository

rP Phorge

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Sten created this revision.Oct 25 2023, 08:43

Owners added a reviewer: O1: Blessed Committers.Oct 25 2023, 08:43

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptOct 25 2023, 08:43

Sten requested review of this revision.Oct 25 2023, 08:43

Harbormaster completed remote builds in B867: Diff 1421.Oct 25 2023, 08:43

lgtm

Before this change NULL was indeed implicitly casted to ''

Thanks

This revision is now accepted and ready to land.Oct 25 2023, 09:07

Closed by commit rP318d7a61feab: Fix PhabricatorAuthCSRFEngine.php strncmp(null) PHP 8.1 error. · Explain WhyOct 25 2023, 10:03

This revision was automatically updated to reflect the committed changes.

Sten added a commit: rP318d7a61feab: Fix PhabricatorAuthCSRFEngine.php strncmp(null) PHP 8.1 error.

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

auth/

engine/

PhabricatorAuthCSRFEngine.php

5 lines

O1: Blessed Committers

Diff 1422

View Options

src/applications/auth/engine/PhabricatorAuthCSRFEngine.php

Fix PhabricatorAuthCSRFEngine.php strncmp(null) PHP 8.1 errorClosedPublicActions