Page MenuHomePhorge
Differential D25449

Fix PhabricatorAuthCSRFEngine.php strncmp(null) PHP 8.1 error
ClosedPublic
Actions

Authored by Sten on Oct 25 2023, 08:43.
Tags
None
Referenced Files
F3342539: D25449.1743665206.diff
Wed, Apr 2, 07:26
F3330905: D25449.1743496872.diff
Mon, Mar 31, 08:41
F3310359: D25449.1743194348.diff
Thu, Mar 27, 20:39
F3308707: D25449.1743175007.diff
Thu, Mar 27, 15:16
F3307730: D25449.1743151270.diff
Thu, Mar 27, 08:41
F3306354: D25449.1743127394.diff
Thu, Mar 27, 02:03
F3304566: D25449.1743100679.diff
Wed, Mar 26, 18:37
F3304187: D25449.1743092973.diff
Wed, Mar 26, 16:29
View All 34 Files
Subscribers
Cigaryno
Matthew
tobiaswiese
valerio.bozzolan

Details

Reviewers
valerio.bozzolan
Group Reviewers
O1: Blessed Committers
Maniphest Tasks
T15654: PhabricatorAuthCSRFEngine.php:50 strncmp(): Passing null to parameter #1 ($string1) of type string is deprecated
Commits
rP318d7a61feab: Fix PhabricatorAuthCSRFEngine.php strncmp(null) PHP 8.1 error
Summary

Update PhabricatorAuthCSRFEngine.php such that it doesn't fall over when provided with a null CSRF token under PHP 8.1

Fixes T15654

Test Plan

Do a POST request to phorge.

Diff Detail

Repository
rP Phorge
Branch
csrf (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 867
Build 867: arc lint + arc unit

Revision Contents
Changeset List

PathSizePackages
src/
applications/
auth/
engine/
5 linesO1: Blessed Committers

Diff 1421

View Options

src/applications/auth/engine/PhabricatorAuthCSRFEngine.php

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0