Fix PhabricatorAuthCSRFEngine.php strncmp(null) PHP 8.1 error
ClosedPublic
Actions

Authored by Sten on Oct 25 2023, 08:43.

Details

Reviewers

Group Reviewers

Maniphest Tasks

T15654: PhabricatorAuthCSRFEngine.php:50 strncmp(): Passing null to parameter #1 ($string1) of type string is deprecated

Commits

rP318d7a61feab: Fix PhabricatorAuthCSRFEngine.php strncmp(null) PHP 8.1 error

Summary

Update PhabricatorAuthCSRFEngine.php such that it doesn't fall over when provided with a null CSRF token under PHP 8.1

Fixes T15654

Test Plan

Do a POST request to phorge.

Diff Detail

Repository

rP Phorge

Branch

csrf (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 867
Build 867: arc lint + arc unit

Event Timeline

Sten created this revision.Oct 25 2023, 08:43

Owners added a reviewer: O1: Blessed Committers.Oct 25 2023, 08:43

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptOct 25 2023, 08:43

Sten requested review of this revision.Oct 25 2023, 08:43

Harbormaster completed remote builds in B867: Diff 1421.Oct 25 2023, 08:43

lgtm

Before this change NULL was indeed implicitly casted to ''

Thanks

This revision is now accepted and ready to land.Oct 25 2023, 09:07

Closed by commit rP318d7a61feab: Fix PhabricatorAuthCSRFEngine.php strncmp(null) PHP 8.1 error. · Explain WhyOct 25 2023, 10:03

This revision was automatically updated to reflect the committed changes.

Sten added a commit: rP318d7a61feab: Fix PhabricatorAuthCSRFEngine.php strncmp(null) PHP 8.1 error.

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

auth/

engine/

PhabricatorAuthCSRFEngine.php

5 lines

O1: Blessed Committers

Diff 1421

View Options

src/applications/auth/engine/PhabricatorAuthCSRFEngine.php

Fix PhabricatorAuthCSRFEngine.php strncmp(null) PHP 8.1 errorClosedPublicActions