Page MenuHomePhorge

Fix a PHP 8.1/8.2 deprecated use of strlen a NULL argument
ClosedPublic

Authored by bob on Aug 17 2023, 08:53.
Tags
None
Referenced Files
F3219694: D25401.1741758782.diff
Tue, Mar 11, 05:53
F3216809: D25401.1741716439.diff
Mon, Mar 10, 18:07
F2997040: D25401.1740390818.diff
Sun, Feb 23, 09:53
F2993359: D25401.1740280066.diff
Sat, Feb 22, 03:07
F2993358: D25401.1740280065.diff
Sat, Feb 22, 03:07
F2993003: D25401.1740265350.diff
Fri, Feb 21, 23:02
F2992978: D25401.1740263415.diff
Fri, Feb 21, 22:30
F2962523: D25401.1739180156.diff
Sun, Feb 9, 09:35

Details

Summary

This commit harmonizes PhabricatorNotificationServerRef's getURI and getWebsocketURI methods as discussed in D25382.

Test Plan

This is hard to say since I didn't know how/when this function might be called.

Diff Detail

Repository
rP Phorge
Branch
tmp
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 771
Build 771: arc lint + arc unit

Event Timeline

bob requested review of this revision.Aug 17 2023, 08:53

Thanks bob! You are a good minion. As discussed previously, this is used only in one point and without any argument:

$ grep -R '>getWebsocketURI' .
./src/view/page/PhabricatorStandardPageView.php:        $client_uri = $server->getWebsocketURI();

So this change seems perfectly legitimate to me. Thanks for this fix!

This revision is now accepted and ready to land.Aug 18 2023, 07:16