Page MenuHomePhorge

Fix a PHP 8.1/8.2 deprecated use of strlen a NULL argument
ClosedPublic

Authored by bob on Aug 17 2023, 08:53.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jul 14, 13:50
Unknown Object (File)
Sun, Jul 14, 09:48
Unknown Object (File)
Sun, Jul 14, 03:26
Unknown Object (File)
Fri, Jul 12, 00:22
Unknown Object (File)
Fri, Jul 12, 00:21
Unknown Object (File)
Fri, Jul 12, 00:21
Unknown Object (File)
Thu, Jul 11, 13:08
Unknown Object (File)
Tue, Jul 9, 07:01

Details

Summary

This commit harmonizes PhabricatorNotificationServerRef's getURI and getWebsocketURI methods as discussed in D25382.

Test Plan

This is hard to say since I didn't know how/when this function might be called.

Diff Detail

Repository
rP Phorge
Branch
tmp
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 771
Build 771: arc lint + arc unit

Event Timeline

bob requested review of this revision.Aug 17 2023, 08:53

Thanks bob! You are a good minion. As discussed previously, this is used only in one point and without any argument:

$ grep -R '>getWebsocketURI' .
./src/view/page/PhabricatorStandardPageView.php:        $client_uri = $server->getWebsocketURI();

So this change seems perfectly legitimate to me. Thanks for this fix!

This revision is now accepted and ready to land.Aug 18 2023, 07:16