Page MenuHomePhorge

Fix a PHP 8.1/8.2 deprecated use of strlen a NULL argument
ClosedPublic

Authored by bob on Aug 17 2023, 08:53.
Tags
None
Referenced Files
F2329208: D25401.1721955009.diff
Thu, Jul 25, 00:50
Unknown Object (File)
Mon, Jul 22, 14:11
Unknown Object (File)
Mon, Jul 22, 14:11
Unknown Object (File)
Mon, Jul 22, 14:03
Unknown Object (File)
Sun, Jul 21, 16:59
Unknown Object (File)
Sun, Jul 14, 13:50
Unknown Object (File)
Sun, Jul 14, 09:48
Unknown Object (File)
Sun, Jul 14, 03:26

Details

Summary

This commit harmonizes PhabricatorNotificationServerRef's getURI and getWebsocketURI methods as discussed in D25382.

Test Plan

This is hard to say since I didn't know how/when this function might be called.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bob requested review of this revision.Aug 17 2023, 08:53

Thanks bob! You are a good minion. As discussed previously, this is used only in one point and without any argument:

$ grep -R '>getWebsocketURI' .
./src/view/page/PhabricatorStandardPageView.php:        $client_uri = $server->getWebsocketURI();

So this change seems perfectly legitimate to me. Thanks for this fix!

This revision is now accepted and ready to land.Aug 18 2023, 07:16