Fix HarbormasterBuildUnitMessage PHP 8.1 strlen(null) error.
Fixes T15572
Details
Details
- Reviewers
speck - Group Reviewers
O1: Blessed Committers - Maniphest Tasks
- T15572: HarbormasterBuildUnit fails with PHP 8.1 strlen(null) error
- Commits
- rP007e7621f298: Fix HarbormasterBuildUnitMessage PHP 8.1 strlen(null) error
Do an 'arc diff' to a PHP 8.1 Phorge server when doing so will trigger unit tests.
Diff Detail
Diff Detail
- Repository
- rP Phorge
- Branch
- harbourmaster (branched from master)
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 707 Build 707: arc lint + arc unit
Event Timeline
| src/applications/harbormaster/storage/build/HarbormasterBuildUnitMessage.php | ||
|---|---|---|
| 104 | I did initially fix this by providing idx with a default '', but this would not guarantee $path would not be null as idx does return null under some circumstances, even with a default set. | |
| 105 | Other option would be to use phutil_nonempty_string(), and I'll swap to that if anyone cares enough to ask. | |