Differential D25361

Fix strlen(null) PHP 8.1 error when pushing into a fresh repository
ClosedPublic
Actions

Authored by Sten on Jul 28 2023, 13:28.

Details

Reviewers

speck

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15569: git push into a fresh repository fails with PHP 8.1 strlen(null) error

Commits

rP189a5d60478e: Fix strlen(null) PHP 8.1 error when pushing into a fresh repository

Summary

Doing a git push into a fresh repository over https fails with a PHP 8.1 strlen(null) error.

This fixes it.

Fixes T15569

Test Plan

Create an empty repository on a PHP 8.1 Phorge instance
Clone it
Add some data
git push

Diff Detail

Repository

rP Phorge

Branch

gitPush

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 695
Build 695: arc lint + arc unit

Event Timeline

Sten created this revision.Jul 28 2023, 13:28

Owners added a reviewer: O1: Blessed Committers.Jul 28 2023, 13:28

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptJul 28 2023, 13:28

Harbormaster completed remote builds in B695: Diff 1163.Jul 28 2023, 13:28

Sten requested review of this revision.Jul 28 2023, 13:28

speck accepted this revision.Jul 28 2023, 15:23

This revision is now accepted and ready to land.Jul 28 2023, 15:23

Closed by commit rP189a5d60478e: Fix strlen(null) PHP 8.1 error when pushing into a fresh repository. · Explain WhyJul 28 2023, 17:23

This revision was automatically updated to reflect the committed changes.

Sten added a commit: rP189a5d60478e: Fix strlen(null) PHP 8.1 error when pushing into a fresh repository.

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

diffusion/

engine/

DiffusionCommitHookEngine.php

2 lines

O1: Blessed Committers

Diff 1163

View Options

src/applications/diffusion/engine/DiffusionCommitHookEngine.php

Fix strlen(null) PHP 8.1 error when pushing into a fresh repositoryClosedPublicActions