Page MenuHomePhorge
Differential D25326

Add explicit tests for phutil_string_cast
ClosedPublic
Actions

Authored by avivey on Jul 3 2023, 18:10.

Details

Reviewers
speck
Group Reviewers
O1: Blessed Committers
Commits
rARC152ba1f02a31: Add explicit tests for phutil_string_cast
Summary

Test (and document) what phutil_string_cast actually does to some things.

Test Plan

arc unit

Diff Detail

Repository
rARC Arcanist
Branch
phorge (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 628
Build 628: arc lint + arc unit

Event Timeline

avivey created this revision.Jul 3 2023, 18:10
Owners added a reviewer: O1: Blessed Committers.Jul 3 2023, 18:10
Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan and 2 others. · View Herald TranscriptJul 3 2023, 18:10
Harbormaster completed remote builds in B625: Diff 1055.Jul 3 2023, 18:10
avivey requested review of this revision.Jul 3 2023, 18:10
speck added a comment.Jul 3 2023, 18:37

Nice. Could we add some additional tests for Boolean true/false, the number zero, populated and empty array?

avivey updated this revision to Diff 1056.Jul 3 2023, 19:10
  • More test cases
Harbormaster completed remote builds in B626: Diff 1056.Jul 3 2023, 19:10
avivey added inline comments.Jul 3 2023, 19:11
src/utils/__tests__/PhutilUtilsTestCase.php
1083

that's not what I would have expected, but PHP is special.

speck accepted this revision.Jul 3 2023, 21:03

Awesome, tyty

This revision is now accepted and ready to land.Jul 3 2023, 21:03
valerio.bozzolan awarded a token.Jul 3 2023, 21:32
valerio.bozzolan added a comment.Jul 4 2023, 07:20

Maybe we can pass also an object that has a __toString() method

avivey added a comment.Jul 4 2023, 07:22
In D25326#9469, @valerio.bozzolan wrote:

Maybe we can pass also an object that has a __toString() method

do you have an example on how to construct one?

valerio.bozzolan added a comment.EditedJul 4 2023, 07:46
In D25326#9471, @avivey wrote:

Maybe we can pass also an object that has a __toString() method

do you have an example on how to construct one?

Don't kill me but I don't remember the names now but we have classes to build URLs, HTML and Remarkup etc. - all of them has __toString() I think.

avivey updated this revision to Diff 1058.Jul 4 2023, 09:05
  • test with object
Harbormaster completed remote builds in B628: Diff 1058.Jul 4 2023, 09:05
Closed by commit rARC152ba1f02a31: Add explicit tests for phutil_string_cast. · Explain WhyJul 4 2023, 09:06
This revision was automatically updated to reflect the committed changes.
avivey added a commit: rARC152ba1f02a31: Add explicit tests for phutil_string_cast.

Revision Contents
Changeset List

PathSizePackages
src/
utils/
__tests__/
46 linesO1: Blessed Committers

Diff 1058

View Options

src/utils/__tests__/PhutilUtilsTestCase.php

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0