Page MenuHomePhorge
Differential D26076

PHPDoc: Replace misc non-existing types
ClosedPublic
Actions

Authored by aklapper on Mon, Jun 9, 22:08.

Details

Reviewers
valerio.bozzolan
Group Reviewers
O1: Blessed Committers
Commits
rARC0e31a4bd0496: PHPDoc: Replace misc non-existing types
Summary

bytes, file, mask, pair, string_symbol, trace are not valid types. See https://docs.phpdoc.org/guide/references/phpdoc/types.html.

Test Plan

Read docs; run static code analysis.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

aklapper created this revision.Mon, Jun 9, 22:08
Owners added a reviewer: O1: Blessed Committers.Mon, Jun 9, 22:08
Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptMon, Jun 9, 22:08
aklapper requested review of this revision.Mon, Jun 9, 22:08
Harbormaster completed remote builds in B2086: Diff 3199.Mon, Jun 9, 22:08
valerio.bozzolan accepted this revision.Mon, Jun 9, 22:08
This revision is now accepted and ready to land.Mon, Jun 9, 22:08
aklapper added a comment.Tue, Jun 10, 09:20

How the hell did you review this in less than a minute? 😄

Closed by commit rARC0e31a4bd0496: PHPDoc: Replace misc non-existing types. · Explain WhyTue, Jun 10, 09:20
This revision was automatically updated to reflect the committed changes.
aklapper added a commit: rARC0e31a4bd0496: PHPDoc: Replace misc non-existing types.
valerio.bozzolan added a comment.Tue, Jun 10, 09:38

How the hell did you review this in less than a minute? 😄

It's incredible how Phorge is efficient in shooting stuff at my mailbox lol.And I tend to manage emails like "first in, CLOSE IT ASAP ASASP" lol

Revision Contents
Changeset List

Diff 3201

View Options

src/error/PhutilErrorHandler.php

Loading...
View Options

src/repository/api/ArcanistGitAPI.php

Loading...
View Options

src/repository/api/ArcanistMercurialAPI.php

Loading...
View Options

src/upload/ArcanistFileDataRef.php

Loading...
View Options

src/utils/utils.php

Loading...
View Options

src/workflow/ArcanistWorkflow.php

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0