Paths

Table of Contentst

Differential D26075

PHPDoc: Replace non-existing param type id with int
ClosedPublic
Actions

Authored by aklapper on Mon, Jun 9, 21:55.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Commits

rP12a24263b60c: PHPDoc: Replace non-existing param type id with int

Summary

id is not a valid type. See https://docs.phpdoc.org/guide/references/phpdoc/types.html.

Test Plan

Read docs; run static code analysis.

Diff Detail

Repository

rP Phorge

Branch

phpdocKillIdType (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 2085
Build 2085: arc lint + arc unit

Event Timeline

aklapper created this revision.Mon, Jun 9, 21:55

Owners added a reviewer: O1: Blessed Committers.Mon, Jun 9, 21:55

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptMon, Jun 9, 21:55

aklapper requested review of this revision.Mon, Jun 9, 21:55

Harbormaster completed remote builds in B2085: Diff 3198.Mon, Jun 9, 21:55

valerio.bozzolan accepted this revision.Mon, Jun 9, 21:55

This revision is now accepted and ready to land.Mon, Jun 9, 21:55

Closed by commit rP12a24263b60c: PHPDoc: Replace non-existing param type id with int. · Explain WhyTue, Jun 10, 09:22

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rP12a24263b60c: PHPDoc: Replace non-existing param type id with int.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

Packages

src/

applications/

differential/

parser/

DifferentialChangesetParser.php

2 lines

54%

O1: Blessed Committers

infrastructure/

daemon/

workers/

PhabricatorWorker.php

2 lines

36%

O1: Blessed Committers

Diff 3198

View Options

src/applications/differential/parser/DifferentialChangesetParser.php

View Options

src/infrastructure/daemon/workers/PhabricatorWorker.php

PHPDoc: Replace non-existing param type id with intClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 3198

src/applications/differential/parser/DifferentialChangesetParser.php

src/infrastructure/daemon/workers/PhabricatorWorker.php

PHPDoc: Replace non-existing param type id with int
ClosedPublic
Actions

Revision Contents
Changeset List