Explicitly cast int to string when expected by PHP functions
ClosedPublic
Actions

Authored by aklapper on Mon, Jun 9, 17:52.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Commits

rARC2e4bfc2ff61a: Explicitly cast int to string when expected by PHP functions

Summary

Avoid Parameter $foo of function bar expects string, int given output in static code analysis by explicitly casting to string when a return value is an int, or by passing a string by encapsulating an int with apostrophes.

Test Plan

Run static code analysis (phpstan).

Diff Detail

Repository

rARC Arcanist

Branch

castInt2String (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 2079
Build 2079: arc lint + arc unit

Event Timeline

aklapper created this revision.Mon, Jun 9, 17:52

Owners added a reviewer: O1: Blessed Committers.Mon, Jun 9, 17:52

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptMon, Jun 9, 17:52

aklapper requested review of this revision.Mon, Jun 9, 17:52

Harbormaster completed remote builds in B2079: Diff 3192.Mon, Jun 9, 17:52

aklapper retitled this revision from Explicitly cast int to string when expected to Explicitly cast int to string when expected by PHP functions.Mon, Jun 9, 20:51

valerio.bozzolan accepted this revision.Wed, Jun 11, 19:09

This revision is now accepted and ready to land.Wed, Jun 11, 19:09

Closed by commit rARC2e4bfc2ff61a: Explicitly cast int to string when expected by PHP functions. · Explain WhyWed, Jun 11, 20:16

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rARC2e4bfc2ff61a: Explicitly cast int to string when expected by PHP functions.